From: Cliff Wickman <cpw@sgi.com>
To: kexec@lists.infradead.org, mingo@elte.hu
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] x86: copy_oldmem_page using cached addressing
Date: Wed, 08 Sep 2010 10:14:27 -0500 [thread overview]
Message-ID: <E1OtMLz-0001yp-Ia@eag09.americas.sgi.com> (raw)
From: Cliff Wickman <cpw@sgi.com>
The copy of /proc/vmcore to a user buffer proceeds much faster
if the kernel addresses memory as cached.
With this patch we have seen an increase in transfer rate from less than
15MB/s to 80-460MB/s, depending on size of the transfer. This makes
a big difference in time needed to save a system dump.
(Does anyone know of a reason why copy_oldmem_page() would need
to use uncached addresses?)
Diffed against 2.6.36-rc3
Signed-off-by: Cliff Wickman <cpw@sgi.com>
---
arch/x86/kernel/crash_dump_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linus.current/arch/x86/kernel/crash_dump_64.c
===================================================================
--- linus.current.orig/arch/x86/kernel/crash_dump_64.c
+++ linus.current/arch/x86/kernel/crash_dump_64.c
@@ -34,7 +34,7 @@ ssize_t copy_oldmem_page(unsigned long p
if (!csize)
return 0;
- vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
+ vaddr = ioremap_cache(pfn << PAGE_SHIFT, PAGE_SIZE);
if (!vaddr)
return -ENOMEM;
next reply other threads:[~2010-09-08 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 15:14 Cliff Wickman [this message]
2010-09-08 19:19 ` Eric W. Biederman
2010-09-09 7:48 ` Ingo Molnar
2010-09-08 19:42 ` Andi Kleen
2010-09-09 11:57 ` [tip:x86/mm] x86, kdump: Change copy_oldmem_page() to use " tip-bot for Cliff Wickman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1OtMLz-0001yp-Ia@eag09.americas.sgi.com \
--to=cpw@sgi.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®