mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cliff Wickman <cpw@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu
Subject: [PATCH] x86: UV kdump reboot fix
Date: Mon, 06 Dec 2010 16:28:38 -0600	[thread overview]
Message-ID: <E1PPjXy-0004Cs-5F@eag09.americas.sgi.com> (raw)


After a crash dump on an SGI Altix UV system the crash kernel fails to
cause a reboot.
Only the reboot_type of BOOT_ACPI works.
Other boot types ...BOOT_EFI, _KBD, _TRIPLE... fail.

The system's BIOS has an EFI layer, so it is a bit of a mystery to me
why BOOT_EFI fails.  Can someone explain that?

Diffed against 2.6.37-rc2

Signed-off-by: Cliff Wickman <cpw@sgi.com>

---
 arch/x86/kernel/reboot.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux/arch/x86/kernel/reboot.c
===================================================================
--- linux.orig/arch/x86/kernel/reboot.c
+++ linux/arch/x86/kernel/reboot.c
@@ -10,6 +10,7 @@
 #include <linux/dmi.h>
 #include <linux/sched.h>
 #include <linux/tboot.h>
+#include <linux/crash_dump.h>
 #include <acpi/reboot.h>
 #include <asm/io.h>
 #include <asm/apic.h>
@@ -22,6 +23,7 @@
 #include <asm/pci_x86.h>
 #include <asm/virtext.h>
 #include <asm/cpu.h>
+#include <asm/uv/uv.h>
 
 #ifdef CONFIG_X86_32
 # include <linux/ctype.h>
@@ -675,6 +677,10 @@ static void native_machine_restart(char 
 
 	if (!reboot_force)
 		machine_shutdown();
+
+	if (is_uv_system() && is_kdump_kernel())
+		reboot_type = BOOT_ACPI;
+
 	__machine_emergency_restart(0);
 }
 

             reply	other threads:[~2010-12-06 22:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 22:28 Cliff Wickman [this message]
2010-12-22 11:41 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PPjXy-0004Cs-5F@eag09.americas.sgi.com \
    --to=cpw@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®