mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: npiggin@gmail.com, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Important for fs devs: rcu-walk merged upstream
Date: Thu, 13 Jan 2011 17:18:19 +0100	[thread overview]
Message-ID: <E1PdPsR-0004BY-Q3@pomaz-ex.szeredi.hu> (raw)
In-Reply-To: <E1PdOdT-00042k-RM@pomaz-ex.szeredi.hu> (message from Miklos Szeredi on Thu, 13 Jan 2011 15:58:47 +0100)

On Thu, 13 Jan 2011, Miklos Szeredi wrote:
> On Sat, 8 Jan 2011, Nick Piggin wrote:
> > The vfs-scale branch is now upstream. If you haven't
> > looked yet, your filesystem is likely to have been
> > touched, so check it out.
> > 
> > Also look at Documentation/filesystems/porting and
> > path-lookup.txt.
> > 
> > The dcache_lock stuff should have been all done for you
> > (for in-tree filesystems, I can help out of tree fses with
> > conversions there if you ping me offline).
> > 
> > The rcu-walk stuff can be more tricky for your filesystem
> > to take advantage of.
> > 
> > If you supply a .d_revalidate, .permission, or .check_acl,
> > then path walking is going to be slow and unscalable for
> > you.
> > 
> > Out of tree filesystems: you _have_ to at least add a line
> > of code to the above functions in order to specify that
> > you don't want to participate in rcu-walk.
> > 
> > Otherwise, you don't have to care about rcu-walk if you
> > have a legacy or special filesystem like configfs then I'd
> > advise against anything fancy. But if you have a
> > userbase and you expect them to actually do any path
> > lookups into your filesystem, please take a look.
> 
> One other thing: I know ECHILD is safe since no sane filesystem will
> return it in its permission or revalidate callbacks, and even if it
> does that's just a loss of optimization.

And it's not entirely safe either.  A fuse filesystem returning ECHILD
would make nameidata_dentry_drop_rcu() to BUG.  So some sort of errno
filter is necessary in the fuse kernel module.

Thanks,
Miklos

  reply	other threads:[~2011-01-13 16:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-08  2:54 Nick Piggin
2011-01-08  9:10 ` Marco Stornelli
2011-01-11  9:57   ` Nick Piggin
2011-01-11 11:08     ` Miklos Szeredi
2011-01-10 14:38 ` J. R. Okajima
2011-01-11 12:57   ` Nick Piggin
2011-01-11  1:08 ` Joel Becker
2011-01-11 13:06   ` Nick Piggin
2011-01-13 14:58 ` Miklos Szeredi
2011-01-13 16:18   ` Miklos Szeredi [this message]
2011-01-14  1:21     ` Nick Piggin
2011-01-14  8:45       ` Miklos Szeredi
2011-01-14  8:52         ` Nick Piggin
2011-01-14  9:38           ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PdPsR-0004BY-Q3@pomaz-ex.szeredi.hu \
    --to=miklos@szeredi.hu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®