mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cliff Wickman <cpw@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@elte.hu,
	acme@ghostprotocols.net
Subject: [RFC] Performance Events 'Samples' report
Date: Thu, 24 Feb 2011 18:15:26 -0600	[thread overview]
Message-ID: <E1PslLC-0000rj-EF@eag09.americas.sgi.com> (raw)

From: Cliff Wickman <cpw@sgi.com>

The perf command's report prints clock periods under the heading of 'Samples'.
Our applications people have been confused by this "Samples" heading.

perf report -n

# Overhead  Samples            Command         Shared Object                            Symbol
# ........ ..........  ...............  ....................  ................................
#
    99.41%1522136216246         pthreads  pthreads              [.] work_function
     0.33% 4980298302             perf  [kernel.kallsyms]     [k] clear_page_c
     ....

It would be more compact to print the number of samples.  And that would
be consistent with the heading.

Below is the code that displays the periods.  I don't see that the number
of samples is available here, but probably easily could be.
I presume that clock periods are derived from #samples * sample period.

perf/util/hist.c

 640 
 641         if (symbol_conf.show_nr_samples) {
 642                 if (sep)
 643                         ret += snprintf(s + ret, size - ret, "%c%" PRIu64,      *sep, period);
 644                 else
 645                         ret += snprintf(s + ret, size - ret, "%11" PRIu64,      period);
 646         }
 647 

Signed-off-by: Cliff Wickman <cpw@sgi.com>


             reply	other threads:[~2011-02-25  0:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25  0:15 Cliff Wickman [this message]
2011-02-25  2:40 ` Arnaldo Carvalho de Melo
2011-02-25 10:26   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PslLC-0000rj-EF@eag09.americas.sgi.com \
    --to=cpw@sgi.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®