From: Olaf Titz <olaf@bigred.inka.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs
Date: Thu, 06 Oct 2011 20:44:57 +0200 [thread overview]
Message-ID: <E1RBswD-0003hi-Eo@bigred.inka.de> (raw)
In-Reply-To: <1317916878.1823.2.camel@Joe-Laptop>
> It would make more sense as:
>
> +#ifdef CONFIG_PROC_FS
> ext4_proc_root = proc_mkdir("fs/ext4", NULL);
> if (!ext4_proc_root)
> goto out5;
> +#endif
Looks right, but even more logical would be to guard _all_ usage of
ext4_proc_root (and, consequently, the declaration thereof) in #ifdef
CONFIG_PROC_FS. Now it's at least necessary to always do null checks.
Olaf
next prev parent reply other threads:[~2011-10-06 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 15:51 Fabrice Jouhaud
2011-10-06 16:01 ` Joe Perches
2011-10-06 16:44 ` Ted Ts'o
2011-10-06 18:44 ` Olaf Titz [this message]
2011-10-07 8:30 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1RBswD-0003hi-Eo@bigred.inka.de \
--to=olaf@bigred.inka.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®