From: cpw <cpw@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, x86@kernel.org
Subject: [PATCH] x86, UV: null pointer in uv_flush_tlb_others()
Date: Tue, 03 Dec 2013 17:15:30 -0600 [thread overview]
Message-ID: <E1VnzBi-0005yF-MU@eag09.americas.sgi.com> (raw)
The SGI UV tlb shootdown code panics the system with a null pointer
deference if 'nobau' is specified on the boot commandline.
uv_flush_tlb_other() gets called for every flush, whether the BAU is disabled
or not. It should not be keeping the s_enters statistic while the BAU
is disabled.
The panic occurs because, during initialization, init_per_cpu_tunables()
does not set the bcp->statp pointer if nobau was specified.
The code is the same in the 3.12.2 tree.
Cc: <stable@vger.kernel.org> # 3.12.x
Signed-off-by: Cliff Wickman <cpw@sgi.com>
---
arch/x86/platform/uv/tlb_uv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux/arch/x86/platform/uv/tlb_uv.c
===================================================================
--- linux.orig/arch/x86/platform/uv/tlb_uv.c
+++ linux/arch/x86/platform/uv/tlb_uv.c
@@ -1070,12 +1070,13 @@ const struct cpumask *uv_flush_tlb_other
unsigned long status;
bcp = &per_cpu(bau_control, cpu);
- stat = bcp->statp;
- stat->s_enters++;
if (bcp->nobau)
return cpumask;
+ stat = bcp->statp;
+ stat->s_enters++;
+
if (bcp->busy) {
descriptor_status =
read_lmmr(UVH_LB_BAU_SB_ACTIVATION_STATUS_0);
next reply other threads:[~2013-12-03 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 23:15 cpw [this message]
2013-12-10 9:22 ` [tip:x86/urgent] x86/UV: Fix NULL pointer dereference in uv_flush_tlb_others() if the 'nobau' boot option is used tip-bot for cpw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1VnzBi-0005yF-MU@eag09.americas.sgi.com \
--to=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®