From: Kyle Moffett <mrmacman_g4@mac.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Ian Lindsay <iml@formicary.org>,
fsdevel@wohnheim.fh-wedel.de, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: LogFS
Date: Sun, 27 Aug 2006 14:02:51 -0400 [thread overview]
Message-ID: <E23E222F-25F8-4C2A-8E16-D4B30C01AFDB@mac.com> (raw)
In-Reply-To: <20060827171728.GB3502@wohnheim.fh-wedel.de>
On Aug 27, 2006, at 13:17:28, Jörn Engel wrote:
> On Sun, 27 August 2006 01:32:45 -0400, Ian Lindsay wrote:
>> +/* FIXME: This should really be somewhere in the 64bit area. */
>> +#define LOGFS_LINK_MAX (2^30)
>>
>> Interesting choice of constant.
>
> Yes. I didn't spend a long time thinking about whether it should
> be 2^31 or 2^31-1 or 2^31-2. It will be a while before it becomes
> an issue in real life anyway. :)
Uhm, I think his point is that "^" is the xor operation:
2^30 == 28
2^31 == 29
2^21-1 == 28
2^21-2 == 31
Probably what you wanted was something more like this:
# define LOGFS_LINK_MAX (1<<30)
Cheers,
Kyle Moffett
next prev parent reply other threads:[~2006-08-27 18:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 13:44 [RFC] LogFS Jörn Engel
2006-08-24 15:37 ` Andi Kleen
2006-08-24 15:54 ` Jörn Engel
2006-08-24 16:37 ` Jan Engelhardt
2006-08-25 4:51 ` Andrew Morton
2006-08-25 8:33 ` Jörn Engel
2006-08-27 5:32 ` LogFS Ian Lindsay
2006-08-27 17:17 ` LogFS Jörn Engel
2006-08-27 18:02 ` Kyle Moffett [this message]
2006-08-27 18:12 ` LogFS Ian Lindsay
2006-08-27 20:16 ` LogFS Jörn Engel
2006-08-27 20:53 ` LogFS Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E23E222F-25F8-4C2A-8E16-D4B30C01AFDB@mac.com \
--to=mrmacman_g4@mac.com \
--cc=fsdevel@wohnheim.fh-wedel.de \
--cc=iml@formicary.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®