From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1D8815E5B8 for ; Tue, 3 Dec 2024 03:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733197248; cv=none; b=JVDiErlbEMu2xglxjXHoxo+yP/jZ8anx1sFvqPvtWaj8S+AARt4v5NKLd32w3VVIaLx9pqS8u0V5LYq2HHxAYR+0fd/k0r/mJrzUhYlgpJLiuWux5q4ZQh32fs0IBtD/J4sIvEtFj7J8l0blhvD8A1H37kpA1JAWTK49l22DiM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733197248; c=relaxed/simple; bh=3/vCR7hd1mkbqmOVXnd6771zf9LhdqojFLaqdaLjkG8=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=vDuM+FiG/fGa1tX64EkOGDKqDnKjnfUCRwm9j0DgCN7AQl5g+O62Hwd4ST+0Gpxhva7MtAAEsQiQ4n7tHASUJJNCf0OHSFhe9Jubd6rR+RckNrEHmBHpRD5oXxhr3qaD1FTKimW/1MaLhVuiOft+qPV1qn41PJMzdyzD4heu6cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=DgrsME63; arc=none smtp.client-ip=91.218.175.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="DgrsME63" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733197242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pB9N0oTEw/DnxiAWtntc/2kC5CGpi8RLUNimhvYmgPE=; b=DgrsME63hX8GcbOf0vPYiRsr6pIvtwNfAJ9uXv2jfBkPzXNOmVvxOHgk65PhIMPNT9nfPc e3mtSF52/kxs+kCvc3cxJ9B59o7AY6d2UDL2RHa0rmGbFy2GH0Vezen4klxTEk+kxuGosz qWoTTHDZtSdb5DCHF25hEmXxNnX/9js= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [PATCH v2] list_lru: expand list_lru_add() docs with info about sublists X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20241129-list_lru_memcg_docs-v2-1-e285ff1c481b@google.com> Date: Tue, 3 Dec 2024 11:40:19 +0800 Cc: Dave Chinner , Andrew Morton , Matthew Wilcox , Johannes Weiner , Nhat Pham , Qi Zheng , Roman Gushchin , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Chinner Content-Transfer-Encoding: 7bit Message-Id: References: <20241129-list_lru_memcg_docs-v2-1-e285ff1c481b@google.com> To: Alice Ryhl X-Migadu-Flow: FLOW_OUT > On Nov 29, 2024, at 22:58, Alice Ryhl wrote: > > The documentation for list_lru_add() and list_lru_del() has not been > updated since lru lists were originally introduced by commit > a38e40824844 ("list: add a new LRU list type"). Back then, list_lru > stored all of the items in a single list, but the implementation has > since been expanded to use many sublists internally. > > Thus, update the docs to mention that the requirements about not using > the item with several lists at the same time also applies not using > different sublists. Also mention that list_lru items are reparented when > the memcg is deleted as discussed on the LKML [1]. > > Also fix incorrect use of 'Return value:' which should be 'Return:'. > > Link: https://lore.kernel.org/all/Z0eXrllVhRI9Ag5b@dread.disaster.area/ [1] > Reviewed-by: Dave Chinner > Signed-off-by: Alice Ryhl Acked-by: Muchun Song Thanks.