From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D85052EC081 for ; Wed, 25 Feb 2026 18:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043972; cv=none; b=Udj3E6D6aPw00abTLGmQnUfIjZiq7irRjlgsOjBeyCGxM89VzBB5vpWC3Jx450vtzVO2znwnWZnLe9SYQoPzH/sIeCPH7zPwQLeHDqRPdgWQQxUKh9vFBkpWBxynwgdseb0/KOHAWOcSOV8W7KII3OZss+RhQhZvs3qaL4TMrm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043972; c=relaxed/simple; bh=v7HzTRvPbojAP+9SBo2Rr+jD4PIy4/P6E/hbZheiRs0=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=bsTQDo1MUfEJ6p4kbKRwkrBm+SRpnv4LleuiDSkcinLt/ePOLk5+gH2owt0NXkXqoTLIBMBfeumKi2SSyoJDU8l9AUaQozJRGFUFaDHLSvYeBhJMZG9mBJS9x8Nvg3D2wSK+gpRk3awyeWa81t9T1axOqEcc7YV7qaaEr3G4q+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d1tRiz1R; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d1tRiz1R" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-1271195d2a7so6028048c88.0 for ; Wed, 25 Feb 2026 10:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772043970; x=1772648770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=3zPxDAA9Z6j2aU+ElViDYNOSqkMrdJ3D+QE/kULkJ0w=; b=d1tRiz1RA7atpbW9du8kicr4ICEUCjGH1LnW+CAkZjjtCX6OnI3YihyhSS969R0zLT HPgskbTpfi/KY8yanExpTnuscWx80m2PMq7SFKTf/v1wtCEPWMux0o6TyGibrHL7v8bR 8IZmUL3t8fcGsG5RqKKxGIp3ebaFELxmkTDuAcbqutNmAxy5KXUzO1NC1RzXzASBNoQd tcPWVddzd3guTi01x3OqsbyBLIkUr46ebcsfDnmNRLzJGjuwIdo83osZ/KW5jFfCMHwK 0NNYKYiQkeAeT3IsY1DYYgW3sEUbhFOYAcIB7wCxVoliBzZ/9awGtCkUJ37HH2wyMXBz oS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772043970; x=1772648770; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3zPxDAA9Z6j2aU+ElViDYNOSqkMrdJ3D+QE/kULkJ0w=; b=c/xPcWR5sWtmPjMW5+Tkw8sIbI2iQ8XybalADzgwr7pvA6spToo++mmnjyImCRKjPK g6wY+hhXP4cpJ7r48xbnz0r/QPDcGyarT/Zq8G3EeuoCoWIEv4uQw99KGX7KI+ONNDUj wSILx7cnXcG9681eHQ2s55O8vzPyF+kIcxbpwG8m4ZlbydcrNn1aX8d63Xly1nsewRsd DAJjN423d9yY1vkUs43yWkUqpf4Akdml7VN8lzEAFuCvhxVJGcjypia6POeGSRAwhq37 IS9Ndn5bOrLIIKLjaGnLLSrIYEx6o68VGe1LfVkEZwDVrh56Zsriu4vXZ0TKio1qzi9m eTzw== X-Forwarded-Encrypted: i=1; AJvYcCVCCLUgvQdJHD2iQAivRt/ZuNn1gAETPemuKMZD2e/fxGJDRItfQMOwMg2oNLukT0gweA1Ohrwaek334cc=@vger.kernel.org X-Gm-Message-State: AOJu0YxcjuiWDeoRuFKko+g9MiA9NDDZXDozTXtFVkWaltthWvmtzMWR 9zT4z4F2M3h8Uuu0eYbmfy+DhsEbFqKRN9NOO2pouGiwXyb6rUfosflP X-Gm-Gg: ATEYQzwBPpjLx1BCPxphLcG8h9nowiNNcnudnKLTlUqygaov5dKT+ZGuzJU9iMHlmou hQdNClT3ZMgQpoZzsqpa8QCgCVX34MoXRudQNhhHjI2Zm7tGtX+6vP0Fg4onLZPVTU77ywR2wzt jreZTW0DVVGT5phua3rbk+O5kkYcDblGbty0QSBM88BD39THgwcf5ukoRlo/in/w+pMpOmIJeEH cGSL3jL7E1Qr89V9rYid778ggoIQ+s2TZH/jdxoSV5THNp9CTPTqqboQtJblTPOxHcw5Ys7kWB0 7dZoTGc74T7sOtzDaHp5p1k0+BvlvWXWl9VUOILX8EPUR2iL9+kdLaRIDYlzYkytv2K6WYTWm8U Iw6skos5mAuCwwQ1jsC4XE21aJl7Csp7pAaGjDA2Yx5eqn/piC5ixx49KDwZws16mBWZyj8uSp3 2p7UtTdX+U2hOSKfg9dkTOikJA89PcE6qyePhsz3i2RNzIs5yOK50b301GdxjxjgugU72inkbti CDERNxFmcETJZR/H9lShg== X-Received: by 2002:a05:7022:511:b0:119:e569:f26c with SMTP id a92af1059eb24-12786990d32mr739802c88.21.1772043969977; Wed, 25 Feb 2026 10:26:09 -0800 (PST) Received: from ehlo.thunderbird.net (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1276af10476sm13520774c88.2.2026.02.25.10.26.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 10:26:09 -0800 (PST) Date: Wed, 25 Feb 2026 10:26:11 -0800 From: "Derek J. Clark" To: Rong Zhang , =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= , Hans de Goede CC: Mark Pearson , Armin Wolf , Jonathan Corbet , Kurt Borja , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_0/6=5D_platform-x86=3A_le?= =?US-ASCII?Q?novo-wmi=3A_Add_fixes_and_enhancement?= User-Agent: Thunderbird for Android In-Reply-To: References: <20260224043200.2680384-1-derekjohn.clark@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On February 25, 2026 10:02:21 AM PST, Rong Zhang wrote: >Hi Derek, > >Sorry for the late reply=2E I was busier (yet happier ;-)) than I had >expected during the Spring Festival/Chinese New Year=2E Not a problem, glad you enjoyed your time off=2E >On Tue, 2026-02-24 at 04:31 +0000, Derek J=2E Clark wrote: >> This series adds many much needed features and fixes to the lenovo-wmi >> drivers=2E >>=20 >> Patch 1 adds a macro to make assigning attribute ID's for capdata >> cleaner and easier=2E >> Patch 2 addresses bugs where devices that don't support exposed >> attributes would still create the attribute, and also attempts to >> identify the correct capdata and set/get methods as some legacy >> interfaces don't use the custom mode in the method or capdata ID=2E >> Patch 3 adds the remaining CPU attributes that weren't previously >> exposed=2E >> Patch 4 adds the GPU attributes that weren't previously exposed=2E >> Patch 5 consolidates name constants in preparation for patch 6=2E >> Patch 6 adds battery charge-type limiting when supported only by WMI=2E >>=20 >> After applying Rong's series from >> https://lore=2Ekernel=2Eorg/platform-driver-x86/20260210191938=2E137234= -1-i@rong=2Emoe/ >> I found that there weren't any conflicts, so rather than combine >> the series we can just review each separately=2E >>=20 >> Signed-off-by: Derek J=2E Clark > >The patch series makes sense to me in general except for some issues >mentioned in my previous replies=2E > >With style issues fixed, you can add > >Reviewed-By: Rong Zhang > >to patch 1,3,4,5=2E > >Thanks, >Rong Thanks, will do after we agree on some of the details=2E Cheers, Derek >> --- >> v3: >> - Re-add HWMON name const and jsut rename LWMI_OM_FW_ATTR_BASE_PATH >> - Fix linker warnings by moving acpi/battery include to the end of th= e >> list=2E >> - Remove CPU/GPU OC features=2E These attributes are BOOL type and wi= ll >> need a new constructor that I'll add later=2E >> v2: >> - Fix gpu_mode misisng from attributes list=2E >> - Fix prototypes for power suppy patch=2E >> - Reorganize CPU and GPU attributes alphabetically=2E >> - Break out the patch consolidating the driver name cost=2E >> - Move some of the refactoring of attribute_id back to into patch 1 >> where it belongs=2E >> - Fix some additional typos in function prototypes=2E >> v1: https://lore=2Ekernel=2Eorg/platform-driver-x86/20260213081243=2E79= 4288-1-derekjohn=2Eclark@gmail=2Ecom/ >>=20 >> Derek J=2E Clark (6): >> platform/x86: lenovo-wmi-other: Add LWMI_ATTR_ID Macro >> platform/x86: lenovo-wmi-other: Limit adding attributes to supported >> devices >> platform/x86: lenovo-wmi-other: Add missing CPU tunable attributes >> platform/x86: lenovo-wmi-other: Add GPU tunable attributes >> platform-x86: lenovo-wmi-other: Rename LWMI_OM_FW_ATTR_BASE_PATH >> platform/x86: lenovo-wmi-other: Add WMI battery charge limiting=2E >>=20 >> =2E=2E=2E/wmi/devices/lenovo-wmi-other=2Erst | 21 + >> drivers/platform/x86/lenovo/wmi-capdata=2Eh | 13 +- >> drivers/platform/x86/lenovo/wmi-gamezone=2Eh | 1 + >> drivers/platform/x86/lenovo/wmi-other=2Ec | 605 ++++++++++++++++= -- >> 4 files changed, 593 insertions(+), 47 deletions(-)