From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 143503AB460 for ; Sat, 3 Oct 2026 09:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791021150; cv=none; b=dNbaYVW9gHdskEEXk1o77p4+ZCp2mKsKa3/MCMb0sn01/SgrpZsSNZ/WTY5MqCF2K195hkyGSmwm0tzx/qyhi21OMtU+m2Pqi8eJqdkE53qacmaflC2i+5VUsiDIgBJWCBKIlzHIzWqOh1y/juoZDqpqWgt4Xtg0lCRDJCJijWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791021150; c=relaxed/simple; bh=jweMfYQRoaoBEfkGOCvQZk+QPSNSvCLvtEJzzzW4538=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=cK5MJ7FyW9CgiTqksbXPLZrgTjKMmu5OPP2DD8lnCYdycdadwVdGH/UYLr0l3QJsDbiVGWaSqqTrgHkKrk8nkKxQlhzjDJucCFXj5Wy9aW3LZzRu3OJlQzsKTplljyCIourr4aaE0sM6ck2VBBInzDdDe3HwFfbCtYGak1gFwEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cpmdls5k; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bKPEJjeg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cpmdls5k"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bKPEJjeg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791021148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bGwiD5BsIU7SMUvm8z3LsVJJc+9NsNqtDssS4ilkK84=; b=cpmdls5kI46cIEXNBJt56HU8LEMwFkBSAPhlQy/2n6rY1g+RMEM49B8ur4gCVepwNZxw5K n7E/hUQWCRjd20cXFR0yb0EUjTR75RYmfLRX6stTyA3MUAtGgtro3CM4ODGFog9C/mmrjl mUjTnLFFoem6cUZcWgM1WzxYMy+9mZI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-jLoN64kpMI-91UcadqXQKQ-1; Sat, 03 Oct 2026 05:52:26 -0400 X-MC-Unique: jLoN64kpMI-91UcadqXQKQ-1 X-Mimecast-MFC-AGG-ID: jLoN64kpMI-91UcadqXQKQ_1791021145 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48af5a07314so187565f8f.2 for ; Sat, 03 Oct 2026 02:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1791021145; x=1791625945; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=bGwiD5BsIU7SMUvm8z3LsVJJc+9NsNqtDssS4ilkK84=; b=bKPEJjegf22xt7UE8YfEPOgMbyGJzt5CIs8Tc5Dpxgfd1wjBgZgKgUU4gbAXqmY5x7 xwrd60yb0DLuTsdcLhT3haEj7DfRPe4U9q/jD2qBWWOFLVYe47GBPxRRrcIpGYnItU+j 8fAUeFParZrJ9N4IjROpH1CaZ4VOuAM20WLfhAjCmfvUNLNMTPquguZVw5YDH3uwvcMI b3c5y9TqUGxT1wMIgykAapiAXFbJ/J23/ZZbQ9TJm3JD5cZhDd7wRvMUgXHPdsxxikgF hQmFPlMhqLJShzARM6CckGgJJdRsOwyt7D8o4J/HchNrSNVeJZr3BSkXmC9QvYHcDKLw RdfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791021145; x=1791625945; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bGwiD5BsIU7SMUvm8z3LsVJJc+9NsNqtDssS4ilkK84=; b=nFGdSXO2pBTzNfuW/C+KSrmSMOOGED8Tzi93tvafroBpjPojcYtRaAI+B55iGw8HO1 Ym66pCOP2A3JG4SIrp90Jcr6uVTbVmmfv4ljTlAFlELkNS93119Yn/4Ut5dK86kePyun /j7l3kz04VhwVsNGs9B0FCfCxb8zUlw4fARrFlVpdYKwW8YnrLwLQLXk/+J7SJUyzODg gNlZ9tRhItw8ROoela3NXIWaJJNjkYhPjlLKrWCHvMijbjbd/6wOI1mD6AdUXaAfm75M 4pWMvGhXCJDvq4s+rH0HQ9QJy9pgUxbZwk7o1gbjTGweuWKRFyAbeujQukAMQb8zszbW 1u1g== X-Forwarded-Encrypted: i=1; AKwUvBwq4t496NYPWpd19trE7a8Atvk4C/YZbdBaqRhaDnt1QG0+DT/GdlohElphsDRRTd3Mif1motabtoWlwgQ=@vger.kernel.org X-Gm-Message-State: AFq9FYJ2qgpA3ESDZQfA4VXhD7ZaWkraB0ZxAfi55mDjlJ+F8d8hyHO6 y8oLkHtBPQT8a1tV1VTTzUO8qdFwq127IjtZX2oQHuJ49RCwLcXcYmPeTvE7/CIYDFJs+IgFh/c ea1GL8Wg7B5F2tQEKNHA8fygrBMFvaEXSPCyf8qkoYhd2BDma6J84lC5ayJQQjmql0g== X-Gm-Gg: AYBFou1hlwSLl2WWVeysbuIGAyMjKwdNVlrilV2IKKlMJ33lkjOOwDtZ1uUVgyDS4wG NY/XblF8yHUkP8mZlGWQ+q1mJOeZJwwUCCnRtkM9LRX+R7pOLjCHd+lVXTPVNoGu8RQBGySeV88 QL1jgy/CcYAeIOTNV9Z9aJq8+9X3R6FFlzg+iFEzjzVKgcRA/6qZTHvsszAEi1zv67tpAK+7S4r qgbjQ2GDF34XLmCPhE8NNeVmfeBYHy8rHt/tA6HlINYnSiMmOAqG2JB8tF6vKexeP+iRmfeX4BI A/5utE0d5q+IiyzKMwHpkHd7jthLhj9KyyR2cfIztLJkZE6A/EK6J+GQvBW+hMOCA0+8Z2wmLhp nRWBKuyhR/totNNnHS09P1cpAJxEuD4jzm21eZQU= X-Received: by 2002:a5d:64c9:0:b0:488:8437:b8b7 with SMTP id ffacd0b85a97d-48b126f1596mr9932284f8f.7.1791021145323; Sat, 03 Oct 2026 02:52:25 -0700 (PDT) X-Received: by 2002:a5d:64c9:0:b0:488:8437:b8b7 with SMTP id ffacd0b85a97d-48b126f1596mr9932244f8f.7.1791021144825; Sat, 03 Oct 2026 02:52:24 -0700 (PDT) Received: from ehlo.thunderbird.net ([2a00:e580:bf11:1:2666:d874:79e6:3214]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b380f0613sm12752818f8f.13.2026.10.03.02.52.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Oct 2026 02:52:24 -0700 (PDT) Date: Sat, 03 Oct 2026 11:52:22 +0200 From: Ivan Vecera To: Petr Oros , netdev@vger.kernel.org CC: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Henry Tieman , Anirudh Venkataramanan , Michal Swiatkowski , Jesse Brandeburg , Preethi Banala , Kiran Patil , Dan Nowlin , Stephen Hemminger , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_iwl-net_01/10=5D_ice=3A_replay_UDP?= =?US-ASCII?Q?_tunnel_ports_after_a_core_or_global_reset?= User-Agent: Thunderbird for Android In-Reply-To: <20261002130752.2597259-2-poros@redhat.com> References: <20261002130752.2597259-1-poros@redhat.com> <20261002130752.2597259-2-poros@redhat.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 2, 2026 3:07:43 PM GMT+02:00, Petr Oros wro= te: >A CORER, GLOBR or EMPR reloads the DDP package in ice_rebuild() and >ice_init_pkg_hints() clears hw->tnl, so every offloaded VXLAN and GENEVE >port is gone from both the boost TCAM and the driver table=2E The >udp_tunnel_nic core is never told about it and still considers the ports >programmed, so the Rx tunnel offloads silently stop working after the >reset=2E With VXLAN port 4789 offloaded, 64 flows that differ only in the >inner headers are spread over all six Rx queues of the test port by >RSS, after a CORER they all land in a single queue, the same as without >the port=2E Removing the port later trips the WARN_ON() in >ice_destroy_tunnel() because its table entry is no longer valid: > > WARNING: ice_flex_pipe=2Ec:524 at ice_udp_tunnel_unset_port+0x56/0x280 = [ice] > ice 0000:04:00=2E3 enp4s0f3np3: Error removing UDP tunnel - -5 > ice 0000:04:00=2E3 enp4s0f3np3: UDP tunnel port sync failed port 4789 t= ype vxlan: -5 > >Call udp_tunnel_nic_reset_ntf() once the main VSI is rebuilt so the core >programs the ports again=2E A PF reset keeps the package and the table, s= o >it is left alone=2E No rtnl_lock is needed since commit 1ead7501094c >("udp_tunnel: remove rtnl_lock dependency")=2E > >i40e fixed the same problem in commit 1f190d936948 ("i40e: Reprogram >port offloads after reset")=2E > >Fixes: a4e82a81f573 ("ice: Add support for tunnel offloads") >Assisted-by: LLM >Signed-off-by: Petr Oros >--- > drivers/net/ethernet/intel/ice/ice_main=2Ec | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/intel/ice/ice_main=2Ec b/drivers/net/et= hernet/intel/ice/ice_main=2Ec >index 8c4b0fbc790644=2E=2Ef2121e79fca993 100644 >--- a/drivers/net/ethernet/intel/ice/ice_main=2Ec >+++ b/drivers/net/ethernet/intel/ice/ice_main=2Ec >@@ -7859,8 +7859,11 @@ static void ice_rebuild(struct ice_pf *pf, enum ic= e_reset_req reset_type) > ice_rebuild_arfs(pf); > } >=20 >- if (vsi && vsi->netdev) >+ if (vsi && vsi->netdev) { > netif_device_attach(vsi->netdev); >+ if (reset_type !=3D ICE_RESET_PFR) >+ udp_tunnel_nic_reset_ntf(vsi->netdev); >+ } >=20 > ice_update_pf_netdev_link(pf); >=20 Reviewed-by: Ivan Vecera