From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-35.mta0.migadu.com [91.218.175.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DDC53E00AA for ; Thu, 3 Sep 2026 06:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416262; cv=none; b=tg/PBWiBmxEDGOv4hLTvoIJrjnHKSCYm/jVQv73GyEsqg5oyCvFuKMoIibdvOM71bwbSzhiapHmeqFaGOGlg2uDyOzZ6+/eJkKs+EmFcOPuS57ifcjy2xO6Lr1s2DjEhXX6kitEkKzyOgUz1yq/2ffgoemkAcy6yan3ZQl2f9+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788416262; c=relaxed/simple; bh=qfDv57uIWsnOlT1w0+UzNsl5Tfmu4rytKxkaLXjRnNY=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=B0ljKHbe3yC+5SmvjHzA3Gtg6gm7SzazgwifbMhq6BtTGcBNrN7s87pVYEDa/h+Xd1ZovSoUhAVFigEHNhc8/GfJj2sg1iW1v9Uua7qQA9SlvfLhTMwnVrljeTWLPcEg0usv1N9NMDI/KfUcLQ4nRwjziQnxVSepmJubL+0KgvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=COF3tCID; arc=none smtp.client-ip=91.218.175.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="COF3tCID" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=qfDv57uIWsnOlT1w0+UzNsl5Tfmu4rytKxkaLXjRnNY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788416257; v=1; x=1789021057; b=COF3tCIDTOSDXzADGQry3tyJwYwceLvp4DXycmm/DJ0ob1i22DzIw7kTMSbS8uFek0eb/SS5 kTVU9vywrF3yeaZXpR+yWeEQGOFEUPP+hXU2YAuh8dUGasnmsfOkgF2hnqZKqwvOuI1890sy1RR gLJnaiDRLizPVyw3H7yiaNmw= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta12.migadu.com with ESMTPS id 015fc451421f2d60; Thu, 03 Sep 2026 06:17:36 +0000 X-Mizu-Trace-ID: 015fc451421f2d60 X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\)) Subject: Re: [PATCH 2/2] nvdimm/pmem: Remove test_and_clear_pmem_poison() From: Muchun Song In-Reply-To: <20260903053535.17611-3-kaitao.cheng@linux.dev> Date: Thu, 3 Sep 2026 14:17:19 +0800 Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dan Williams , Vishal Verma , Dave Jiang , Alison Schofield , Ira Weiny , linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, Kaitao Cheng Content-Transfer-Encoding: 7bit Message-Id: References: <20260903053535.17611-1-kaitao.cheng@linux.dev> <20260903053535.17611-3-kaitao.cheng@linux.dev> To: Kaitao Cheng X-Mailer: Apple Mail (2.3864.700.51.1.1) > On Sep 3, 2026, at 13:35, Kaitao Cheng wrote: > > From: Kaitao Cheng > > TestClearPageHWPoison() is now defined regardless of whether > CONFIG_MEMORY_FAILURE is enabled, returning false when memory failure > handling is unavailable. > > The test_and_clear_pmem_poison() wrapper duplicates this configuration > handling and has no other pmem-specific behavior. > > Call TestClearPageHWPoison() directly and remove the redundant wrapper. > This also removes the need to include page-flags.h from pmem.h. > > No functional change is intended. > > Signed-off-by: Kaitao Cheng The code becomes simpler. Acked-by: Muchun Song Thanks.