From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964972AbcJQTNC (ORCPT ); Mon, 17 Oct 2016 15:13:02 -0400 Received: from mail-qt0-f178.google.com ([209.85.216.178]:35886 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934666AbcJQTMw (ORCPT ); Mon, 17 Oct 2016 15:12:52 -0400 Subject: Re: [PATCH 10/10] hwmon: i2cs-fan: Add hwmon dts binding documentation Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: Pantelis Antoniou In-Reply-To: <20161010202903.GA9122@rob-hp-laptop> Date: Mon, 17 Oct 2016 22:12:58 +0300 Cc: Lee Jones , Linus Walleij , Alexandre Courbot , Mark Rutland , Frank Rowand , Wolfram Sang , Richard Purdie , Jacek Anaszewski , Jean Delvare , Peter Rosin , Avirup Banerjee , Georgi Vlaev , Guenter Roeck , JawaharBalaji Thirumalaisamy , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-leds@vger.kernel.org, linux-hwmon@vger.kernel.org Message-Id: References: <1475853669-22480-1-git-send-email-pantelis.antoniou@konsulko.com> <1475853669-22480-11-git-send-email-pantelis.antoniou@konsulko.com> <20161010202903.GA9122@rob-hp-laptop> To: Rob Herring X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9HJD6Gg005191 > On Oct 10, 2016, at 23:29 , Rob Herring wrote: > > On Fri, Oct 07, 2016 at 06:21:09PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev >> >> Adds the I2CS Fan Tray hwmon device tree node documentation. >> >> Signed-off-by: Georgi Vlaev >> [Ported from Juniper kernel] >> Signed-off-by: Pantelis Antoniou >> --- >> Documentation/devicetree/bindings/hwmon/i2cs-fan.txt | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/i2cs-fan.txt >> >> diff --git a/Documentation/devicetree/bindings/hwmon/i2cs-fan.txt b/Documentation/devicetree/bindings/hwmon/i2cs-fan.txt >> new file mode 100644 >> index 0000000..4ef880c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/i2cs-fan.txt >> @@ -0,0 +1,19 @@ >> +Hwmon driver for Juniper fan trays on I2CS Slave FPGA > > This is a h/w description, not a driver. > >> + >> +Required properties: >> + >> +- compatible: "i2cs-fan-hwmon" > > I doubt any fan control h/w has "hwmon" in the name. > >> + >> +Optional properties: >> + >> +- num-fans: fans per tray (default 14) >> + >> +- tach-factor: TACH count scaling factor (default 120) > > vendor prefixes needed. > >> + >> +Example: >> + >> +fan-hwmon { >> + compatible = "jnx,i2cs-fan-hwmon"; >> + num-fans = <6>; >> + tach-factor = <33>; >> +}; >> -- >> 1.9.1 OK on all three.