From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from confino.investici.org (confino.investici.org [93.190.126.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7172B15E97; Mon, 29 Jun 2026 12:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.190.126.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737671; cv=none; b=So5vEfs4kaa4bRvQxwMsrTsqmLKxr+yaf+091nGu7MytoZip4SAEWQERgGqB6lYlEMpJ87PQyXTJ/+PlBOivDpdQ7XpFFvGMfkks489h33d3E535oEQuVmac//hwpgcIg9BjkMk/J/Or02U2tdxRi+7Ua1+hoJQKGcL7CbRpycY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737671; c=relaxed/simple; bh=Yr2zKvkug4dI0FoY6gt9HvqCWNEGS51SOMCCAsq+dWY=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=TrCdku3InoLFPBjEJnPVvazzULT008zO/XM4YU5Ktxq4vuh2x2rI69Vq6NilQtYnf7IBdmykZqJDRQHy1yV50LkoTefyadZENcNtt7LDkiSNfTeZ+BxwtoGEc4MQhMdPmYmO3GHpsc2KGktCoYJDK81RwUvXM6xD4yDH84YxApU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=grrlz.net; spf=pass smtp.mailfrom=grrlz.net; dkim=pass (1024-bit key) header.d=grrlz.net header.i=@grrlz.net header.b=WDetH3qX; arc=none smtp.client-ip=93.190.126.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=grrlz.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=grrlz.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=grrlz.net header.i=@grrlz.net header.b="WDetH3qX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grrlz.net; s=stigmate; t=1782737660; bh=UHUQRvDxYITmVwJqOWXIA6FbFpYX5crfejyYhqfNw4I=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=WDetH3qXTPfYUMMVLgKKdgLCjJGFOGE1hzMktByZ01Y6g2pLwMGDqIOWJWebNLGm9 82z4IAsviEKmPgjYzNAIaix1+rB/YoHBQlVLZFpKBms2BKk/HjzcBgbvgyDi3z9pbw Z7zg4HxqRbVZl1AfxIy7SVjU67evtbCAhg+xPeQk= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4gpmSX3Q7bz110G; Mon, 29 Jun 2026 12:54:20 +0000 (UTC) Received: by mx1.investici.org (Postfix) id 4gpmSX0XQWz110B; Mon, 29 Jun 2026 12:54:20 +0000 (UTC) Date: Mon, 29 Jun 2026 13:54:18 +0100 From: Bradley Morgan To: Feng Tang , Petr Mladek CC: Andrew Morton , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Madhavan Srinivasan , Douglas Anderson , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_4/4=5D_panic=3A_use_sys=5Finfo=5Fwi?= =?US-ASCII?Q?th=5Ffilter=28=29_to_avoid_duplicate_backtraces?= In-Reply-To: References: <20260625152558.7450-1-include@grrlz.net> <20260625152558.7450-5-include@grrlz.net> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 29 June 2026 12:40:52 BST, Feng Tang wrote: >On Fri, Jun 26, 2026 at 02:14:14PM +0200, Petr Mladek wrote: >> On Fri 2026-06-26 12:23:50, Petr Mladek wrote: >> > On Thu 2026-06-25 15:25:58, Bradley Morgan wrote: >> > > panic_other_cpus_shutdown() handles SYS_INFO_ALL_BT before stopping >the >> > > other CPUs. Do not ask sys_info() to handle that bit again later in >the >> > > panic path. >> > > >> > > Use sys_info_with_filter() so panic_print=all_bt does not request >more >> > > output after the CPUs are stopped. >> > > >> > > Fixes: a9af76a78760 ("watchdog: add sys_info sysctls to dump sys >info on system lockup") >> > > Cc: stable@vger.kernel.org >> > > Signed-off-by: Bradley Morgan >> > > --- >> > > kernel/panic.c | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/kernel/panic.c b/kernel/panic.c >> > > index 213725b612aa..eb842823df61 100644 >> > > --- a/kernel/panic.c >> > > +++ b/kernel/panic.c >> > > @@ -680,7 +680,7 @@ void vpanic(const char *fmt, va_list args) >> > > */ >> > > atomic_notifier_call_chain(&panic_notifier_list, 0, buf); >> > > >> > > - sys_info(panic_print); >> > > + sys_info_with_filter(panic_print, SYS_INFO_ALL_BT); >> > >> > Hmm, this prevents printing backtraces from all CPUs completely. >> > But what if they were not printed? >> > >> > They might be printed by: >> > >> > static void panic_other_cpus_shutdown(bool crash_kexec) >> > { >> > if (panic_print & SYS_INFO_ALL_BT) >> > panic_trigger_all_cpu_backtrace(); >> > >> > [...] >> > } >> > >> > But it checks only "panic_print" variable. It won't do anything >> > when (panic_print == 0). >> > >> > In this case, we might still want to print the backraces when >> > SYS_INFO_ALL_BT is set in kernel_si_info. >> > >> > > kmsg_dump_desc(KMSG_DUMP_PANIC, buf); >> > >> > Of course, we might fix panic_other_cpus_shutdown() to check also >> > kernel_si_info. >> > >> > But it all becomes very hairy. We have several levels: >> > >> > + watchdog-all_bt-specific option, e.g. >sysctl_hardlockup_all_cpu_backtrace >> > >> > + watchdog-specific si_info preferences, e.g. hardlockup_si_mask >> > >> > + panic-specific si_info: panic_print >> > >> > + universal fallback for any layer: kernel_si_info >> > >> > Now, we try to check all these variables back and forth to >> > trigger all backtraces or to avoid triggering them. >> > And it clearly does not work well and the code is more and more >> > hairy. >> > >> > I think about another approach. The word "waterfall" comes to my mind. >> > Instead of checking all the settings back and forth, let's process >> > each setting one by one and just remember what has been done and >> > skip this in the next level. >> > >> > All the si_info actions seems to dump a global system state. >> > So, it would make sense to remember the state in a global variable >> > even when it might be modified by more CPUs in parallel. >> > >> > I am going to think more about it. >> >> I have created a POC using Gemini. I haven't tested it. >> But it looks acceptable. And the logic seems to be more >> straightforward. >> >> One drawback is that it requires adding the _reset() >> call for all sys_info() callers. It is fine in principle >> but it might complicate back-porting because all changes >> have to be done in one patch. >> >> But honestly, this is a nice to have fix. Most people could >> live happily without it. >> >> From 3c66436d9978030845a96bfaedd6b914536e2ac4 Mon Sep 17 00:00:00 2001 >> From: Petr Mladek >> Date: Fri, 26 Jun 2026 13:55:41 +0200 >> Subject: [POC] sys_info: Introduce state-tracking APIs to prevent >duplicate >> backtraces >> >> In watchdog, panic, and hung task detection scenarios, sys_info() can >> be called multiple times or alongside direct backtrace triggers like >> trigger_allbutcpu_cpu_backtrace(). This results in identical backtraces >> being dumped repeatedly from all CPUs, cluttering the kernel log and >> delaying or obscuring critical debug details. >> >> Introduce a state tracking bitmask and associated helpers: >> - sys_info_done(mask): Marks specific sys_info bits as already printed. >> - sys_info_reset(): Resets the tracking state. >> - sys_info_is_done(mask): Checks if all bits in the mask have been >printed. >> >> Update sys_info() to automatically filter out already printed bits >> using this state. Integrate these APIs with the generic hardlockup >> and softlockup watchdogs, the PowerPC watchdog, the hung task detector, >> and the panic core. This ensures that each piece of system information >> and backtrace output is printed at most once per lockup/panic event, >> and the state is reset cleanly when a lockup does not trigger a panic. >> >> Races between sys_info() callers are ignored. It should be acceptable >> because the output from various watchdogs has never been synchronized. >> And panic() never returns. >> >> Assisted-by: gemini-1.5-flash >> Signed-off-by: Petr Mladek > >Yep. There are cases that people want panic on task-hung or sw/hw lockup, >and this could remove much duplication of sys info dump, thanks! > >Reviewed-by: Feng Tang Thanks, im feeling a new file to do all the force panic jazz, but putting tape on sys_info.c isn't bd either. >> --- >> arch/powerpc/kernel/watchdog.c | 13 ++++++++++--- >> include/linux/sys_info.h | 3 +++ >> kernel/hung_task.c | 2 ++ >> kernel/panic.c | 4 +++- >> kernel/watchdog.c | 10 ++++++++-- >> lib/sys_info.c | 30 +++++++++++++++++++++++++++++- >> 6 files changed, 55 insertions(+), 7 deletions(-) > Thanks!