From: Paolo Valente <paolo.valente@linaro.org>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
linux-block <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] block, bfq: set default slice_idle to zero for non-rotational devices
Date: Fri, 2 Nov 2018 21:18:26 +0300 [thread overview]
Message-ID: <E50DB19F-D744-4E6B-ADDC-A2546484ADF0@linaro.org> (raw)
In-Reply-To: <317076f7-f84f-c08f-5fb5-b227094cabfd@applied-asynchrony.com>
> Il giorno 1 nov 2018, alle ore 22:06, Holger Hoffstätte <holger@applied-asynchrony.com> ha scritto:
>
> On 11/01/18 18:43, Konstantin Khlebnikov wrote:
>> With default 8ms idle slice BFQ is up to 10 times slower than CFQ
>> for massive random read workloads for common SATA SSD.
>> For now zero idle slice gives better out of box experience.
>> CFQ employs this since commit 41c0126b3f22 ("block: Make CFQ default
>> to IOPS mode on SSDs")
>
> Well, that's interesting because 3 years ago I made the same suggestion
> and was told that BFQ's heuristics automagically make it not idle when
> rotational=0.
Yep, that automagic is probably 50% of the good of BFQ.
If one just sets slice_idle=0, then throughput is always maximum with
random I/O; but there is no control on I/O any longer.
At any rate, Konstantin, if you have some use case where BFQ fails,
I'll be very glad to analyze it, and hopefully improve BFQ. Just one
request: use at least a 4.19.
Thanks,
Paolo
> Did you actually benchmark this? I just tried and don't
> get a noticeable performance difference with slice_idle=0 compared to
> deadline.
>
> Discussion link:
> https://groups.google.com/forum/#!msg/bfq-iosched/iRMw2n3kYLY/6l9cIm3TBgAJ
>
> curious..
>
> Holger
prev parent reply other threads:[~2018-11-02 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 17:43 Konstantin Khlebnikov
2018-11-01 19:06 ` Holger Hoffstätte
2018-11-02 18:18 ` Paolo Valente [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E50DB19F-D744-4E6B-ADDC-A2546484ADF0@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=holger@applied-asynchrony.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®