From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15516C6FA8A for ; Thu, 8 Sep 2022 11:29:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231258AbiIHL3t (ORCPT ); Thu, 8 Sep 2022 07:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbiIHL3q (ORCPT ); Thu, 8 Sep 2022 07:29:46 -0400 Received: from hutie.ust.cz (hutie.ust.cz [185.8.165.127]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E868B18B0B; Thu, 8 Sep 2022 04:29:42 -0700 (PDT) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail; t=1662636574; bh=eA2LMCy4I214W/X512BaZYIk9y7xAY0TdZeYuwcrUnM=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=mrzaxyx6V/uFgjAWurZEr3sq5LP2vqupdTG4Sad9liAwF7U47bMDSRCVzE+8pgDYj U3S9PNkA+QF1l9PjI1eDBYJu+5qeTOHgIKmu4QO7BwG8kWq0+CljGW5nPPtCqLKrxI TaIdqkMQtfnca25A0/5N1Cl6B7Mr1O2vaW8iHR3I= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH v2 2/5] dt-bindings: net: Add Broadcom BCM4377 family PCIe Bluetooth From: =?utf-8?Q?Martin_Povi=C5=A1er?= In-Reply-To: Date: Thu, 8 Sep 2022 13:29:30 +0200 Cc: Sven Peter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hector Martin , Alyssa Rosenzweig , asahi@lists.linux.dev, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220907170935.11757-1-sven@svenpeter.dev> <20220907170935.11757-3-sven@svenpeter.dev> To: Krzysztof Kozlowski Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 8. 9. 2022, at 13:19, Krzysztof Kozlowski = wrote: >=20 > On 07/09/2022 19:09, Sven Peter wrote: >> These chips are combined Wi-Fi/Bluetooth radios which expose a >> PCI subfunction for the Bluetooth part. >> They are found in Apple machines such as the x86 models with the T2 >> chip or the arm64 models with the M1 or M2 chips. >>=20 >> Signed-off-by: Sven Peter >> --- >> changes from v1: >> - added apple,* pattern to brcm,board-type >> - s/PCI/PCIe/ >> - fixed 1st reg cell inside the example to not contain the bus number >>=20 >> .../bindings/net/brcm,bcm4377-bluetooth.yaml | 78 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 79 insertions(+) >> create mode 100644 = Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml >>=20 >> diff --git = a/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml = b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml >> new file mode 100644 >> index 000000000000..fb851f8e6bcb >> --- /dev/null >> +++ = b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml >> @@ -0,0 +1,78 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/brcm,bcm4377-bluetooth.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Broadcom BCM4377 family PCIe Bluetooth Chips >> + >> +allOf: >> + - $ref: bluetooth-controller.yaml# >=20 > Put it before properties (so after description). >=20 >> + >> +maintainers: >> + - Sven Peter >> + >> +description: >> + This binding describes Broadcom BCM4377 family PCIe-attached = bluetooth chips >> + usually found in Apple machines. The Wi-Fi part of the chip is = described in >> + bindings/net/wireless/brcm,bcm4329-fmac.yaml. >> + >> +properties: >> + compatible: >> + enum: >> + - pci14e4,5fa0 # BCM4377 >> + - pci14e4,5f69 # BCM4378 >> + - pci14e4,5f71 # BCM4387 >> + >> + reg: >> + description: PCI device identifier. >=20 > maxItems: X >=20 >> + >> + brcm,board-type: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: Board type of the Bluetooth chip. This is used to = decouple >> + the overall system board from the Bluetooth module and used to = construct >> + firmware and calibration data filenames. >> + On Apple platforms, this should be the Apple module-instance = codename >> + prefixed by "apple,", e.g. "apple,atlantisb". >> + pattern: '^apple,.*' >> + >> + brcm,taurus-cal-blob: >> + $ref: /schemas/types.yaml#/definitions/uint8-array >> + description: A per-device calibration blob for the Bluetooth radio. = This >> + should be filled in by the bootloader from platform configuration >> + data, if necessary, and will be uploaded to the device. >> + This blob is used if the chip stepping of the Bluetooth module does = not >> + support beamforming. >=20 > Isn't it: > s/beamforming/beam forming/ > ? Doesn=E2=80=99t seem like it: https://www.google.com/search?hl=3Den&q=3Dbeam%20forming Best, Martin >> + >> + brcm,taurus-bf-cal-blob: >> + $ref: /schemas/types.yaml#/definitions/uint8-array >> + description: A per-device calibration blob for the Bluetooth radio. = This >> + should be filled in by the bootloader from platform configuration >> + data, if necessary, and will be uploaded to the device. >> + This blob is used if the chip stepping of the Bluetooth module = supports >> + beamforming. >=20 > Same here. > Best regards, > Krzysztof