From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 239D2C4167B for ; Tue, 28 Nov 2023 17:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345426AbjK1RTM (ORCPT ); Tue, 28 Nov 2023 12:19:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjK1RTK (ORCPT ); Tue, 28 Nov 2023 12:19:10 -0500 Received: from mail.zytor.com (unknown [IPv6:2607:7c80:54:3::138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B8F410CB; Tue, 28 Nov 2023 09:19:17 -0800 (PST) Received: from [127.0.0.1] ([98.35.210.218]) (authenticated bits=0) by mail.zytor.com (8.17.2/8.17.1) with ESMTPSA id 3ASHIMck585558 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Tue, 28 Nov 2023 09:18:23 -0800 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 3ASHIMck585558 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2023111101; t=1701191904; bh=f6l68iGv5eAcjwGj55E8OL6CF5X9iU8J74t2PrTG5YA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=6XE+gwUSIscmXlxZmR/obyqPnRdyFc9SgOdDhOLZ5zIn1Qj3I3XIlJN7R91edhLqJ 3ATaGYKTRv7hC69ocMawcn/GiY4V77tWz594FEnWHS1T/g+UF3/dc6k9z0gaybTIHl sdQV9dZqS9FscMeWhYHdMnochTHoBUVyrWGiTY2zNzeuYMHsP9gBs5xV7h8+eLlOz8 5O5NkXqRyj9mjLrHrEoT9mG7b2dvs/x/bc4pP1UavUy6IAgToEPxAtQdtXqZvS6W9m YOJM6Xe1gTSAM8HoXUXn+o/WwGXl2uufOA2uqrbGW6boguYBo3j4/dND+m2saj1FAf JdMK7bWrvWlow== Date: Tue, 28 Nov 2023 09:18:21 -0800 From: "H. Peter Anvin" To: Borislav Petkov , Xin Li CC: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, pbonzini@redhat.com, seanjc@google.com, peterz@infradead.org, jgross@suse.com, ravi.v.shankar@intel.com, mhiramat@kernel.org, andrew.cooper3@citrix.com, jiangshanlai@gmail.com, nik.borisov@suse.com Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v12_16/37=5D_x86/ptrace=3A_Add_FRED_ad?= =?US-ASCII?Q?ditional_information_to_the_pt=5Fregs_structure?= User-Agent: K-9 Mail for Android In-Reply-To: <20231128085122.GPZWWqCrPYnzB8BqFB@fat_crate.local> References: <20231003062458.23552-1-xin3.li@intel.com> <20231003062458.23552-17-xin3.li@intel.com> <20231128085122.GPZWWqCrPYnzB8BqFB@fat_crate.local> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On November 28, 2023 12:51:22 AM PST, Borislav Petkov wrot= e: >On Mon, Oct 02, 2023 at 11:24:37PM -0700, Xin Li wrote: >> FRED defines additional information in the upper 48 bits of cs/ss >> fields=2E Therefore add the information definitions into the pt_regs >> structure=2E >>=20 >> Specially introduce a new structure fred_ss to denote the FRED flags >> above SS selector, which avoids FRED_SSX_ macros and makes the code >> simpler and easier to read=2E >>=20 >> Signed-off-by: H=2E Peter Anvin (Intel) > >You and hpa need to go through all the patches and figure out who's the >author that's going to land in git=2E > >Because this and others have hpa's SOB first, suggesting he's the >author=2E However, the mail doesn't start with > >From: H=2E Peter Anvin (Intel) > >and then git will make *you* the author=2E > >> Tested-by: Shan Kang >> Signed-off-by: Thomas Gleixner >> Signed-off-by: Xin Li > >=2E=2E=2E > >> union { >> - u64 ssx; // The full 64-bit data slot containing SS >> - u16 ss; // SS selector >> + /* SS selector */ >> + u16 ss; >> + /* The extended 64-bit data slot containing SS */ >> + u64 ssx; >> + /* The FRED SS extension */ >> + struct fred_ss fred_ss; > >Aha, sanity about the right comments has come to your mind in this next >patch=2E :-P > >Just do them right in the previous one=2E > >> /* >> - * Top of stack on IDT systems=2E >> + * Top of stack on IDT systems, while FRED systems have extra fields >> + * defined above for storing exception related information, e=2Eg=2E = CR2 or >> + * DR6=2E > >Btw, I really appreciate the good commenting - thanks for that! > For Xin, mainly: Standard practice is: 1=2E For a patch with relatively small modifications, or where the changes= are mainly in comments or the patch message: Keep the authorship, but put a description of what you have changed in bra= ckets with your username at the bottom of the description, immediately befo= re Signed-off-by: [ xin: changed foo, bar, baz ] 2=2E For a patch with major rewrites: Take authorship on the From: line, but have an Originally-by: tag (rather = than a Signed-off-by: by the original author): Originally-by: Someone Else 3=2E For a patch which is fully or nearly fully your own work (a total rew= rite, or based on a concept idea rather than actual code), credit the origi= nal in the patch comment: Based on an idea by Someone Else (optional link = to lore=2Ekernel=2Eorg)=2E