From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06AD6C6778A for ; Thu, 5 Jul 2018 21:50:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1E6F23FF8 for ; Thu, 5 Jul 2018 21:50:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1E6F23FF8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zytor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898AbeGEVu0 convert rfc822-to-8bit (ORCPT ); Thu, 5 Jul 2018 17:50:26 -0400 Received: from terminus.zytor.com ([198.137.202.136]:57941 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451AbeGEVuZ (ORCPT ); Thu, 5 Jul 2018 17:50:25 -0400 Received: from wld62.hos.anvin.org (c-24-5-245-234.hsd1.ca.comcast.net [24.5.245.234] (may be forged)) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id w65LoD8b1202289 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 5 Jul 2018 14:50:13 -0700 Date: Thu, 05 Jul 2018 14:50:05 -0700 User-Agent: K-9 Mail for Android In-Reply-To: <20180705200912.GA10701@linux.intel.com> References: <20180703182118.15024-1-jarkko.sakkinen@linux.intel.com> <20180703182118.15024-6-jarkko.sakkinen@linux.intel.com> <20180705200912.GA10701@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH v12 05/13] x86/sgx: architectural structures To: Jarkko Sakkinen , Dave Hansen CC: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" From: hpa@zytor.com Message-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On July 5, 2018 1:09:12 PM PDT, Jarkko Sakkinen wrote: >On Thu, Jul 05, 2018 at 08:31:42AM -0700, Dave Hansen wrote: >> On 07/03/2018 11:19 AM, Jarkko Sakkinen wrote: >> > +struct sgx_secs { >> > + uint64_t size; >> > + uint64_t base; >> > + uint32_t ssaframesize; >> > + uint32_t miscselect; >> > + uint8_t reserved1[SGX_SECS_RESERVED1_SIZE]; >> > + uint64_t attributes; >> > + uint64_t xfrm; >> > + uint32_t mrenclave[8]; >> > + uint8_t reserved2[SGX_SECS_RESERVED2_SIZE]; >> > + uint32_t mrsigner[8]; >> > + uint8_t reserved3[SGX_SECS_RESERVED3_SIZE]; >> > + uint16_t isvvprodid; >> > + uint16_t isvsvn; >> > + uint8_t reserved4[SGX_SECS_RESERVED4_SIZE]; >> > +} __packed __aligned(4096); >> >> Why are the uint* versions in use here? Those are for userspace ABI, >> but this is entirely for in-kernel-use, right? >> >> We've used u8/16/32/64 in arch code in a bunch of places. They're at >> least a bit more compact and easier to read. It's this: >> >> u8 foo; >> u64 bar; >> >> vs. this: >> >> uint8_t foo; >> uint64_t bar; > >The reason was that with in-kernel LE these were in fact used by >user space code. Now they can be changed to those that you >suggested. > >/Jarkko For things exported to user space use __u* and __s* types... the _t types would actually violate the C standard with respect to namespace pollution. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.