From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04309C67871 for ; Mon, 16 Jan 2023 21:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234514AbjAPV3z (ORCPT ); Mon, 16 Jan 2023 16:29:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234410AbjAPV3a (ORCPT ); Mon, 16 Jan 2023 16:29:30 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D3E52BEF9 for ; Mon, 16 Jan 2023 13:29:10 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id x40so10325947lfu.12 for ; Mon, 16 Jan 2023 13:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=FqTPgVEI+/l0Z2M0FqNHN/wbtlAyAwzZL0OO5z8BaCc=; b=jhMWQjDKGdbCHydqu5ubgmaJLHdxpngHI5nIJF0VbdiS0N39R/lmWztXM0FfDp/deu 9W+CdGTu3IqFjDdhFus0JXhdV1t8Afe4N3GXQNZgkaOwo3waflvGyJRpE4Z2/NiQvbhw pnxs7b1q0YWuQgkDeRHi8tXd+keSvtCEb+IoDiE8PJ+5kxdHUnYEVDsQF781coj2Xu+y UwYTNj69ieAKeoZ7BLs0fYqxYrol4bv7oWT3XoNzlJFI7I3AEgbesFMWqZgKNAEph5Uu isYn0HT2hOwcdFvWvZT/2vju2xbuxMW9HttRClnJoqXQ89KrMieXnDQLFK37RzrB6V26 VtYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FqTPgVEI+/l0Z2M0FqNHN/wbtlAyAwzZL0OO5z8BaCc=; b=Kd1ufkSzOlJIQgJ/1Ndvq1Gp1W8o9pdZHYLuLkjjaE5IlmgXO0XZZ8ixSFNa6BOuP9 UqAJOrgjnQYXhh25wNYSLNNO7Rw/natBUUrtMXhgIAJuwrgImq1orEEUKnsAsk7kId7L ZTGu2UzK4qKNye1AXv1dlu6mudZBX19GtBT+TUy3853zH3qvZctcXPPO9eEnegAvRV+O dFQ9MxfXQa8m1O/hsp5Cc2kj1tjeq1dlx9mwnWtar/KdI3uUad25OMheX/k+aj4xOjqX xpManAprZQ//WnOYS/wASRTnKl78JZRVIq0LvHkPjGTn+fu+Id71/vIAukMFbQ0+wsOc Lgqw== X-Gm-Message-State: AFqh2krukUmmqCwBUzQCR82jZghCiwCbKUs3+t8/PASMAcN+nf15d42C meX55ay5XgOmeyzjBHWm5oHm2A== X-Google-Smtp-Source: AMrXdXuufVRubDriD/2a/Gz86R2bSzUvxoguE9Cq9tfcujYu1aRL76EHwPDPPYn9I3UYwcsO/DL6hw== X-Received: by 2002:ac2:4f04:0:b0:4a4:68b8:f4bd with SMTP id k4-20020ac24f04000000b004a468b8f4bdmr143452lfr.3.1673904548546; Mon, 16 Jan 2023 13:29:08 -0800 (PST) Received: from [127.0.0.1] (85-76-18-55-nat.elisa-mobile.fi. [85.76.18.55]) by smtp.gmail.com with ESMTPSA id j11-20020a056512344b00b004d580823c25sm128540lfr.11.2023.01.16.13.29.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 13:29:08 -0800 (PST) Date: Mon, 16 Jan 2023 23:29:04 +0200 From: Dmitry Baryshkov To: Christian Marangi CC: Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Krzysztof Kozlowski , Rob Herring Subject: Re: [PATCH v7 1/7] dt-bindings: clock: Convert qcom,krait-cc to yaml User-Agent: K-9 Mail for Android In-Reply-To: <63c5bf92.050a0220.bca9b.5439@mx.google.com> References: <20230116204751.23045-1-ansuelsmth@gmail.com> <20230116204751.23045-2-ansuelsmth@gmail.com> <63c5bf92.050a0220.bca9b.5439@mx.google.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 16 =D1=8F=D0=BD=D0=B2=D0=B0=D1=80=D1=8F 2023 =D0=B3=2E 23:20:17 GMT+02:00, = Christian Marangi =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >On Mon, Jan 16, 2023 at 11:14:10PM +0200, Dmitry Baryshkov wrote: >> On Mon, 16 Jan 2023 at 22:48, Christian Marangi wrote: >> > >> > Convert qcom,krait-cc to yaml Documentation=2E >> > >> > Signed-off-by: Christian Marangi >> > Reviewed-by: Krzysztof Kozlowski >> > Acked-by: Rob Herring >>=20 >> I know this has been reviewed already=2E I checked again my apq8064 >> branch and noticed that the bindings are not compatible with the >> apq8064=2E The SoC in question is a 4-core device, so this is what I ha= d >> in mind: >>=20 >> kraitcc: clock-controller { >> compatible =3D "qcom,krait-cc-v1"; >> clocks =3D <&gcc PLL9>, /* hfpll0 */ >> <&gcc PLL10>, /* hfpll1 */ >> <&gcc PLL16>, /* hfpll2 */ >> <&gcc PLL17>, /* hfpll3 */ >> <&gcc PLL12>, /* hfpll_l2 */ >> <&acc0>, >> <&acc1>, >> <&acc2>, >> <&acc3>, >> <&l2cc>; >> clock-names =3D "hfpll0", >> "hfpll1", >> "hfpll2", >> "hfpll3", >> "hfpll_l2", >> "acpu0_aux", >> "acpu1_aux", >> "acpu2_aux", >> "acpu3_aux", >> "acpu_l2_aux"; >> #clock-cells =3D <1>; >> }; >>=20 > >Oh wow=2E=2E=2E Wasn't aware, but I wonder if a good idea would be to pat= ch >the yaml if and when this series is merged? This is a direct conversion >of the krait-cc txt=2E=2E=2E > >If we really want I can send a v8 with adding these extra stuff to the >just converted yaml in a different commit? (afaik conversion should not >add more info if the documentation is not broken enough and can be >converted) I think we can ask Bjorn to pick the rest of the patches (if they are acke= d/reviewed, they look good to me) and work on this one=2E It might make sen= se to add per-SoC compatibles=2E Also note, the qsb clock=2E Which block ge= nerates it on ipq8064? > >> > --- >> > =2E=2E=2E/bindings/clock/qcom,krait-cc=2Etxt | 34 ---------= -- >> > =2E=2E=2E/bindings/clock/qcom,krait-cc=2Eyaml | 59 +++++++++= ++++++++++ >> > 2 files changed, 59 insertions(+), 34 deletions(-) >> > delete mode 100644 Documentation/devicetree/bindings/clock/qcom,krai= t-cc=2Etxt >> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,krai= t-cc=2Eyaml >> > >> > diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc=2E= txt b/Documentation/devicetree/bindings/clock/qcom,krait-cc=2Etxt >> > deleted file mode 100644 >> > index 030ba60dab08=2E=2E000000000000 >> > --- a/Documentation/devicetree/bindings/clock/qcom,krait-cc=2Etxt >> > +++ /dev/null >> > @@ -1,34 +0,0 @@ >> > -Krait Clock Controller >> > - >> > -PROPERTIES >> > - >> > -- compatible: >> > - Usage: required >> > - Value type: >> > - Definition: must be one of: >> > - "qcom,krait-cc-v1" >> > - "qcom,krait-cc-v2" >> > - >> > -- #clock-cells: >> > - Usage: required >> > - Value type: >> > - Definition: must be 1 >> > - >> > -- clocks: >> > - Usage: required >> > - Value type: >> > - Definition: reference to the clock parents of hfpll, secondar= y muxes=2E >> > - >> > -- clock-names: >> > - Usage: required >> > - Value type: >> > - Definition: must be "hfpll0", "hfpll1", "acpu0_aux", "acpu1_a= ux", "qsb"=2E >> > - >> > -Example: >> > - >> > - kraitcc: clock-controller { >> > - compatible =3D "qcom,krait-cc-v1"; >> > - clocks =3D <&hfpll0>, <&hfpll1>, <&acpu0_aux>, <&acpu= 1_aux>, ; >> > - clock-names =3D "hfpll0", "hfpll1", "acpu0_aux", "acp= u1_aux", "qsb"; >> > - #clock-cells =3D <1>; >> > - }; >> > diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc=2E= yaml b/Documentation/devicetree/bindings/clock/qcom,krait-cc=2Eyaml >> > new file mode 100644 >> > index 000000000000=2E=2E8caa5a677394 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/clock/qcom,krait-cc=2Eyaml >> > @@ -0,0 +1,59 @@ >> > +# SPDX-License-Identifier: GPL-2=2E0-only OR BSD-2-Clause >> > +%YAML 1=2E2 >> > +--- >> > +$id: http://devicetree=2Eorg/schemas/clock/qcom,krait-cc=2Eyaml# >> > +$schema: http://devicetree=2Eorg/meta-schemas/core=2Eyaml# >> > + >> > +title: Qualcomm Krait Clock Controller >> > + >> > +maintainers: >> > + - Christian Marangi >> > + >> > +description: | >> > + Qualcomm Krait Clock Controller used to correctly scale the CPU an= d the L2 >> > + rates=2E >> > + >> > +properties: >> > + compatible: >> > + enum: >> > + - qcom,krait-cc-v1 >> > + - qcom,krait-cc-v2 >> > + >> > + clocks: >> > + items: >> > + - description: phandle to hfpll for CPU0 mux >> > + - description: phandle to hfpll for CPU1 mux >> > + - description: phandle to CPU0 aux clock >> > + - description: phandle to CPU1 aux clock >> > + - description: phandle to QSB fixed clk >> > + >> > + clock-names: >> > + items: >> > + - const: hfpll0 >> > + - const: hfpll1 >> > + - const: acpu0_aux >> > + - const: acpu1_aux >> > + - const: qsb >> > + >> > + '#clock-cells': >> > + const: 1 >> > + >> > +required: >> > + - compatible >> > + - clocks >> > + - clock-names >> > + - '#clock-cells' >> > + >> > +additionalProperties: false >> > + >> > +examples: >> > + - | >> > + clock-controller { >> > + compatible =3D "qcom,krait-cc-v1"; >> > + clocks =3D <&hfpll0>, <&hfpll1>, >> > + <&acpu0_aux>, <&acpu1_aux>, <&qsb>; >> > + clock-names =3D "hfpll0", "hfpll1", >> > + "acpu0_aux", "acpu1_aux", "qsb"; >> > + #clock-cells =3D <1>; >> > + }; >> > +=2E=2E=2E >> > -- >> > 2=2E37=2E2 >> > >>=20 >>=20 >> --=20 >> With best wishes >> Dmitry >