From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 637AE32D43C for ; Mon, 2 Mar 2026 05:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772430950; cv=none; b=mixrCldv99HO5YaXqAa2i3yHOLvWgmswnuJ9/0CKRa1vXi0Ndwr9cBXdDs6iKLKfCcY/AQP4eRyKxAYqtgJgqAz2BCcUYQsa4y39Xs16S+/wpc28ojZqpgYqJNdPTlBmLz7moWJVcBoh/Zvbig3t5FFlIgyFlkz1yhHUBaGQSDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772430950; c=relaxed/simple; bh=E28PYxEby162HDiG+ZHzQXYypL1443yUoh3vpe4Ronk=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=hrbjuje2R55Eg5OdW41wNCnDa3Va7+7AnkehQbnJ2jFPzVjsGEhMA13NkSEn0yul93HeMuW/LJkgj/IMg9ODSsj1BN7tJ0h53tltbVdNJzdaj7fDtlUcEmTKl+AgHFWFcKOgUCORCzJ5kvZYcE+1hpFpTuRkH04kcY35Z9x+nRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yo2EfCL4; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yo2EfCL4" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48069a48629so44242375e9.0 for ; Sun, 01 Mar 2026 21:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772430940; x=1773035740; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eaxQozfKHpn+XVw6fWKA0kIBpYvNcT6Pt64DOJc8D1E=; b=Yo2EfCL4Uvkp3PtBbzrj3H5tBCQX8y6Tt8AIoQVuBnwVVUvuiKq2usLWLECxrorIOb 6/R2S4O1/y+c0kP1rPlNgD6MiSHN/cMc5B0prfd5T/eSf4dRRuYzJcScjaY1SQmEXhiU Ok7g6BXWJDrl1FVR14/JDCWEPIHDtORDIsvM0eKBD6H4W94BoE6uYeWe+CCMKdybsvPM IvU1cmRl3VZTWBYw8JXbGn3iWxutT2KN0MKP2DJIkvG4iCX2NkEXZlOe9yFh0bxsSBO0 HHZxfnKmUXRHhMzFFlaUqinY2C9t7BA1RB5qJ0IsBjkQs0PSFOvxdoajdY+pZqPHviNZ 2TLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772430940; x=1773035740; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eaxQozfKHpn+XVw6fWKA0kIBpYvNcT6Pt64DOJc8D1E=; b=Ci2OjjB6ABoGMMBqczInbOv4KtWbzN+nTMqR0vk2TTtFC08ACCwJkPp4FbTecQ7iPN HF0Oei7M+xXfsybhF1N5F46ECzQ6+YI1x/0vjcEhqQ6JrLk7riCqALy041Y35hlUZvQn U02jltJ+gaT9BBadc626n8rKYBn/kmRWABpPr9APOkFlln1put82cTFIvmlW7aMjJk7Q gFDd0tD4tFw+fdJPC5RvrzMjwP0PMq13gGWPjkPthn/fyA0v4wjrHigJnjxxZdYd5+3k IzZ5yx/1tXFfGVlfDGitXFXrJezP7EkO3qZzdXenqqXiCSBrzHHv+zJ3PXpKj69IrKO2 WbTg== X-Forwarded-Encrypted: i=1; AJvYcCWcrhRLY/EF8Wu2icdWgUuG0XhqbfA4sscszxgqgqLr/6NAAP6A3UxK1be+TXiNn6/Zr5NOpGiWYegvskA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyql8rQL3o3Z3anEbjwoFTJHjHD4dL9NY/uJer7kW4tXTdJ6FuL YfE6jjY1W3wF/0NtpmEDy9v9oOSXQQmMGTADl94gOfJ8DKoAtuYfD/Bj X-Gm-Gg: ATEYQzw6KIAWfuUCfPgNR8FAX+kh2uaIKe1h4XiSKag3+gq6QwRL7gHzlIoaMUVdRh1 AoLjTM3FKbMs3vHR56Vc4dZiDTjkOnePfGoKgido04LGUaR/6uk9U+9rN87VgyU/z+NQ+M3EaU6 Y0S6byThTeECmN7umaU/H9pCOXhVZqFcSRorQ2TbgL2mpB0BxJtjlIyXPmIAZhc51VIXz61mFgO jAuzSKvu7YQvDMRuXQZr1aLJiS7sR0yvlI0qjpd0SuFBxSH4JPFEJvCVeaUQ9rwRGDNM3sd9hKv j+f8AqjR5wO7LUpNd6kCUXAN0P+vzJYdSrfuhD+WXtOOpjxBlaFErCsy70ToufrIY0vY5kiLe96 pgUZ4LAKNYd8Fh+1PPR+rybWrB0OqEVvW1ZO18x47HLB/DkmILOx8B2ZAfGks1JTHowKhKm3jh0 rjEV/Si9MmZpnR+wiAFk0M2exdTfkvxz+ufaS47kZ9DMk= X-Received: by 2002:a05:600c:3108:b0:483:709e:f238 with SMTP id 5b1f17b1804b1-483c9c1d177mr192468685e9.29.1772430940303; Sun, 01 Mar 2026 21:55:40 -0800 (PST) Received: from smtpclient.apple ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfccd7b6sm123940475e9.24.2026.03.01.21.55.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Mar 2026 21:55:39 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: [PATCH] wifi: rtw89: retry efuse physical map dump on transient failure From: Christian Hewitt In-Reply-To: Date: Mon, 2 Mar 2026 09:55:27 +0400 Cc: Bitterblue Smith , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260301042422.195491-1-christianshewitt@gmail.com> To: Ping-Ke Shih X-Mailer: Apple Mail (2.3864.400.21) > On 2 Mar 2026, at 9:47=E2=80=AFam, Ping-Ke Shih = wrote: >=20 > Christian Hewitt wrote: >> On Radxa Rock 5B with a RTL8852BE combo WiFi/BT card, the efuse >> physical map dump intermittently fails with -EBUSY during probe. >> The failure occurs in rtw89_dump_physical_efuse_map_ddv() where >> read_poll_timeout_atomic() times out waiting for the B_AX_EF_RDY >> bit after 1 second. >=20 > I'm checking internally how we handle this case. >=20 > [...] >=20 >>=20 >> For context, firmware also fails (and recovers) sometimes: >=20 > Did you mean this doesn't always happen? sometimes? It=E2=80=99s another intermittent behaviour observed on this board (and = not related to the issue this patch targets). It occurs less frequently than the efuse issue and the existing retry mechanism in the driver ensures firmware load always succeeds. > We has seen similar log because of 36-bit DMA. Try below to force 32- = or 36- > bit DMA to see if it can resolve problem in your platform. I can experiment but this doesn=E2=80=99t happen often so I probably = can=E2=80=99t provide meaningful feedback. Christian > diff --git a/drivers/net/wireless/realtek/rtw89/pci.c = b/drivers/net/wireless/realtek/rtw89/pci.c > index 43c61b3dc969..9d003ab93c85 100644 > --- a/drivers/net/wireless/realtek/rtw89/pci.c > +++ b/drivers/net/wireless/realtek/rtw89/pci.c > @@ -3305,6 +3305,8 @@ static bool = rtw89_pci_is_dac_compatible_bridge(struct rtw89_dev *rtwdev) > if (!bridge) > return false; >=20 > + return true; // or force to return false; > + > switch (bridge->vendor) { > case PCI_VENDOR_ID_INTEL: > return true; >=20 >>=20 >> ROCK5B:~ # dmesg | grep rtw89 >> [ 6.436873] rtw89_8852be 0002:21:00.0: loaded firmware = rtw89/rtw8852b_fw-1.bin >> [ 6.437165] rtw89_8852be 0002:21:00.0: enabling device (0000 -> = 0003) >> [ 6.450228] rtw89_8852be 0002:21:00.0: Firmware version 0.29.29.15 = (6fb3ec41), cmd version 0, type 5 >> [ 6.450239] rtw89_8852be 0002:21:00.0: Firmware version 0.29.29.15 = (6fb3ec41), cmd version 0, type 3 >> [ 7.864148] rtw89_8852be 0002:21:00.0: fw security fail >> [ 7.864154] rtw89_8852be 0002:21:00.0: download firmware fail >> [ 7.864160] rtw89_8852be 0002:21:00.0: [ERR]fwdl 0x1E0 =3D 0x62 >> [ 7.864165] rtw89_8852be 0002:21:00.0: [ERR]fwdl 0x83F0 =3D = 0x80011 >> [ 7.864173] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931150 >> [ 7.864188] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931150 >> [ 7.864203] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864219] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864234] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864250] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931150 >> [ 7.864265] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931150 >> [ 7.864281] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931150 >> [ 7.864296] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864311] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864327] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864342] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931150 >> [ 7.864358] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864373] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 7.864387] rtw89_8852be 0002:21:00.0: [ERR]fw PC =3D 0xb8931154 >> [ 8.181342] rtw89_8852be 0002:21:00.0: chip info CID: 0, CV: 1, = AID: 0, ACV: 1, RFE: 1 >> [ 8.184322] rtw89_8852be 0002:21:00.0: rfkill hardware state = changed to enable >>=20 >=20 >=20