From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758922AbdJQW66 convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 18:58:58 -0400 Received: from mga06.intel.com ([134.134.136.31]:63075 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624AbdJQW6z (ORCPT ); Tue, 17 Oct 2017 18:58:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,392,1503385200"; d="scan'208";a="1206927505" From: "Dilger, Andreas" To: "Gustavo A. R. Silva" CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , Lustre Development List , "devel@driverdev.osuosl.org" , "Shehata, Amir" , Linux Kernel Mailing List Subject: Re: [PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs Thread-Topic: [PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs Thread-Index: AQHTQ3YDJky5HcUu60y5+ocnZOJSAqLpJV4A Date: Tue, 17 Oct 2017 22:58:41 +0000 Message-ID: References: <498af25d3ec36c899f8b3071ce32c7937a4a038f.1507781178.git.garsilva@embeddedor.com> In-Reply-To: <498af25d3ec36c899f8b3071ce32c7937a4a038f.1507781178.git.garsilva@embeddedor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.142.85] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lnet/selftest/module.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c > index b5d556f..fa1bccc 100644 > --- a/drivers/staging/lustre/lnet/selftest/module.c > +++ b/drivers/staging/lustre/lnet/selftest/module.c > @@ -57,10 +57,13 @@ lnet_selftest_exit(void) > switch (lst_init_step) { > case LST_INIT_CONSOLE: > lstcon_console_fini(); > + /* fall through */ > case LST_INIT_FW: > sfw_shutdown(); > + /* fall through */ > case LST_INIT_RPC: > srpc_shutdown(); > + /* fall through */ > case LST_INIT_WI_TEST: > for (i = 0; > i < cfs_cpt_number(lnet_cpt_table()); i++) { > @@ -72,7 +75,7 @@ lnet_selftest_exit(void) > sizeof(lst_sched_test[0]) * > cfs_cpt_number(lnet_cpt_table())); > lst_sched_test = NULL; > - > + /* fall through */ > case LST_INIT_WI_SERIAL: > cfs_wi_sched_destroy(lst_sched_serial); > lst_sched_serial = NULL; > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation