From: Ron Niles <Ron.Niles@falconstor.com>
To: linux-kernel@vger.kernel.org
Cc: Hugh Dickins <hugh@veritas.com>
Subject: RE: Question about free_one_pgd() changes in these 3.5G patches
Date: Wed, 16 Jul 2003 09:23:43 -0400 [thread overview]
Message-ID: <E79B8AB303080F4096068F046CD1D89B01247A59@exchange1.FalconStor.Net> (raw)
>On Tue, 15 Jul 2003, Ron Niles wrote:
>>
>> /*
>> * Beware if changing the loop below. It once used int j,
>> * for (j = 0; j < PTRS_PER_PMD; j++)
>> * free_one_pmd(pmd+j);
>> * but some older i386 compilers (e.g. egcs-2.91.66, gcc-2.95.3)
>> * terminated the loop with a _signed_ address comparison
>> * using "jle", when configured for HIGHMEM64GB (X86_PAE).
>> * If also configured for 3GB of kernel virtual address space,
>> * if page at physical 0x3ffff000 virtual 0x7ffff000 is used as
>> * a pmd, when that mm exits the loop goes on to free "entries"
>> * found at 0x80000000 onwards. The loop below compiles instead
>> * to be terminated by unsigned address comparison using "jb".
>>
>> for (md = pmd, emd = pmd + PTRS_PER_PMD; md < emd; md++) {
>> prefetchw(md+(PREFETCH_STRIDE/16));
>> free_one_pmd(md);
>> }
>>
>> The comment (found in the AA patch) makes no sense to me. Since j is an
int,
>> you would expect the loop to exit with jle. If you want it to exit on jb,
>> just change j to unsigned, right? Also PTRS_PER_PMD is never very large,
>> around 512 I think, so it really doesn't matter unless PTRS_PER_PMD
exceeds
>> 0x7fffffff, which is really far from reality.
>
>That comment (and the rewritten loop) originally came from me.
>I thought it was a champion comment, I'm saddened that you disagree!
>
>I've tried to cover the point by saying they terminated the loop with
>"a _signed_ address comparison": the loop got optimized in such a way
>that it wasn't testing int j as the C shows, but the address pmd+j.
>
Thanks, Hugh, it _is_ a champion comment, and it makes perfect sense now
that
I understand the compiler-optimized comparison is on pmd+j, not j.
next reply other threads:[~2003-07-16 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-16 13:23 Ron Niles [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-07-16 0:52 Ron Niles
2003-07-16 12:31 ` Hugh Dickins
2003-07-16 15:25 ` Dave Jones
2003-07-16 18:57 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E79B8AB303080F4096068F046CD1D89B01247A59@exchange1.FalconStor.Net \
--to=ron.niles@falconstor.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®