From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbbE0HJk (ORCPT ); Wed, 27 May 2015 03:09:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:58191 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbbE0HJi convert rfc822-to-8bit (ORCPT ); Wed, 27 May 2015 03:09:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,502,1427785200"; d="scan'208";a="732292772" From: "Jie, Yang" To: Takashi Iwai CC: Sudip Mukherjee , "broonie@kernel.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "Girdwood, Liam R" , "Zhang, Vivian" Subject: RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint Thread-Topic: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint Thread-Index: AQHQl7VJWHlM+CCPJk+VWk5+MPRUMZ2Ou5+AgACS+LD//4XJgIAAhv1A Date: Wed, 27 May 2015 07:09:24 +0000 Message-ID: References: <1432646037-23803-1-git-send-email-yang.jie@intel.com> <1432646037-23803-3-git-send-email-yang.jie@intel.com> <20150527044955.GB3096@sudip-PC> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Takashi Iwai [mailto:tiwai@suse.de] > Sent: Wednesday, May 27, 2015 2:19 PM > To: Jie, Yang > Cc: Sudip Mukherjee; broonie@kernel.org; alsa-devel@alsa-project.org; > linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > footprint > > At Wed, 27 May 2015 05:38:01 +0000, > Jie, Yang wrote: > > > > > -----Original Message----- > > > From: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com] > > > Sent: Wednesday, May 27, 2015 12:50 PM > > > To: Jie, Yang > > > Cc: tiwai@suse.de; broonie@kernel.org; alsa-devel@alsa-project.org; > > > linux- kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced > > > memory footprint > > > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, > > > > which can save about 9KB memory size for reducing memory footprint > purpose. > > > > --- > > > missing Signed-off-by. > > > > Thanks for pointing out. > > > > Signed-off-by: Jie Yang > > > > Takashi, do I need to resend them? > > Yes, but you seen to have missed my first comment. Here again: Sorry about the missing. :) > > ========================================================== > ====== > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > + bool "Reduced Memory Footprint Support" > > + default n > > + help > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > + reduce code size and data footprint as much as possible. > > I'd like to move this into sound/core. > Also, the kconfig name appears a bit too lengthy to me. > ========================================================== > ====== > > And, after reading this again, I wonder whether we just take the existing > CONFIG_EXPERT for allowing the selection of more knobs like > CONFIG_SND_PROC_FS. > > SND_PROC_FS > bool "Sound proc file" if EXPERT Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' any more? Or we can keep it as root menu of the set of items, just as below? (I changed it to SND_SMALL_FOOTPRINT, as your comment above) menuconfig SND_SMALL_FOOTPRINT bool "Reduced Memory Footprint Support" if EXPERT default n help Say 'Y' to enable Reduced Memory Footprint Support, which may reduce code size and data footprint as much as possible. config SND_PROC_FS bool "Sound Proc FS Support" if SND_SMALL_FOOTPRINT depends on PROC_FS default y help Say 'N' to disable Sound proc FS, which may reduce code size about 9KB on x86_64 platform. If unsure say Y. ~Keyon > depends on PROC_FS > .... > > > Takashi