From: Kumar Gala <galak@codeaurora.org>
To: Georgi Djakov <gdjakov@mm-sol.com>
Cc: Bjorn Andersson <bjorn@kryo.se>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Russell King <linux@arm.linux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>
Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform
Date: Wed, 15 Oct 2014 09:56:02 +0200 [thread overview]
Message-ID: <E8A71F0C-3BD0-4F1D-A7C2-A4F643429E2F@codeaurora.org> (raw)
In-Reply-To: <543D4C87.9050703@mm-sol.com>
On Oct 14, 2014, at 6:17 PM, Georgi Djakov <gdjakov@mm-sol.com> wrote:
> On 10/10/2014 08:14 PM, Bjorn Andersson wrote:
>> On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov <gdjakov@mm-sol.com> wrote:
>>> Enable support for the two SD host controllers on the APQ8084 platform
>>> by adding the required nodes to the DT files.
>>> On the IFC6540 board, the first controller is connected to the onboard
>>> eMMC and the second is connected to a micro-SD card slot.
>>>
>>> Signed-off-by: Georgi Djakov <gdjakov@mm-sol.com>
>>
>> Hi Georgi,
>>
>> This looks sane, but...
>>
>>> ---
>>> arch/arm/boot/dts/qcom-apq8084-ifc6540.dts | 11 +++++++++++
>>> arch/arm/boot/dts/qcom-apq8084.dtsi | 23 +++++++++++++++++++++++
>>> 2 files changed, 34 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>> index e41cb8a..c9ff108 100644
>>> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>> [..]
>>> + sdhci@f98a4900 {
>>> + cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
>>> + bus-width = <4>;
>>
>> ...why do you add this node and leave it disabled in the dts?
>>
>
> Hi Bjorn,
> Currently only the eMMC is functional on this board, so now we
> have just the board specific configuration under this node.
> More patches are forthcoming.
Can we add something in the commit message to denote this.
- k
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2014-10-15 7:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 15:40 [PATCH v2 0/3] ARM: dts: qcom: Add initial IFC6540 board support Georgi Djakov
2014-09-02 15:40 ` [PATCH v2 1/3] ARM: dts: qcom: Add initial IFC6540 board device tree Georgi Djakov
2014-09-02 15:40 ` [PATCH v2 2/3] ARM: dts: qcom: Enable serial port on IFC6540 boards Georgi Djakov
2014-09-02 15:40 ` [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform Georgi Djakov
2014-10-08 19:18 ` Nicolas Dechesne
2014-10-08 19:45 ` Josh Cartwright
2014-10-09 6:56 ` Nicolas Dechesne
2014-10-10 17:14 ` Bjorn Andersson
2014-10-14 16:17 ` Georgi Djakov
2014-10-15 7:56 ` Kumar Gala [this message]
2014-11-01 15:43 ` Andreas Färber
2014-11-02 8:08 ` Srinivas Kandagatla
2014-09-02 15:54 ` [PATCH v2 0/3] ARM: dts: qcom: Add initial IFC6540 board support Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E8A71F0C-3BD0-4F1D-A7C2-A4F643429E2F@codeaurora.org \
--to=galak@codeaurora.org \
--cc=bjorn@kryo.se \
--cc=devicetree@vger.kernel.org \
--cc=gdjakov@mm-sol.com \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®