From: Muchun Song <muchun.song@linux.dev>
To: Sourav Panda <souravpanda@google.com>
Cc: osalvador@suse.de, david@kernel.org, fvdl@google.com,
gthelen@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] mm/hugetlb: Fix null nodemask in alloc_fresh_hugetlb_folio
Date: Tue, 21 Jul 2026 10:30:20 +0800 [thread overview]
Message-ID: <E8AB5D4D-E781-45B5-B06C-4AAFB2518977@linux.dev> (raw)
In-Reply-To: <20260720173707.47616938378bc26a41650b6a@linux-foundation.org>
> On Jul 21, 2026, at 08:37, Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Sun, 5 Jul 2026 23:55:31 -0700 Sourav Panda <souravpanda@google.com> wrote:
>
>>> - Option 1: Fix it directly within alloc_gigantic_frozen_folio().
>>> This would centrally cover both of its underlying allocation paths:
>>> hugetlb_cma_alloc_frozen_folio() and alloc_contig_frozen_pages().
>>>
>>> - Option 2: Fix hugetlb_cma_alloc_frozen_folio() and alloc_contig_frozen_pages()
>>> separately. The rationale here is that since the buddy allocator
>>> already handles this case internally, and alloc_contig_frozen_pages()
>>> is also a low-level allocator, it would be better to keep their behaviors
>>> consistent.
>>>
>>> Both approaches are viable from my perspective. I'm CCing more MM maintainers
>>> and reviewers to gather your insights and decide on the best path forward.
>>>
>>> Muchun,
>>> Thanks.
>>
>> Gotcha! Thanks Andrew and Muchun!
>>
>> I shall wait for the decision and then send the subsequent version :)
>
> 15 days: no decision shall be forthcoming.
>
> Please code up whatever you consider best then send it out. This will
> trigger a great outpouring of decisions ;)
Hi Sourav,
Please select Option 2 first, as I'd prefer not to make HugeTLB a special case
again.
Thanks.
next prev parent reply other threads:[~2026-07-21 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 17:51 Sourav Panda
2026-07-05 19:04 ` Andrew Morton
2026-07-06 6:17 ` Muchun Song
2026-07-06 6:55 ` Sourav Panda
2026-07-21 0:37 ` Andrew Morton
2026-07-21 2:30 ` Muchun Song [this message]
2026-07-21 5:02 ` Sourav Panda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E8AB5D4D-E781-45B5-B06C-4AAFB2518977@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=fvdl@google.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®