mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Greg.Chandler@wellsfargo.com>
To: <Scott_Kilau@digi.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: kernel oops with extended serial stuff turned on...
Date: Wed, 18 Oct 2006 16:07:21 -0500	[thread overview]
Message-ID: <E8C008223DD5F64485DFBDF6D4B7F71D020C6071@msgswbmnmsp25.wellsfargo.com> (raw)


Should that be made a permanent patch then? 

-----Original Message-----
From: Kilau, Scott [mailto:Scott_Kilau@digi.com] 
Sent: Wednesday, October 18, 2006 3:33 PM
To: Chandler, Greg
Cc: linux-kernel@vger.kernel.org
Subject: RE: kernel oops with extended serial stuff turned on...

Hi Greg,

> kobject_add failed for ttyM0 with -EEXIST, don't try to register
things
> with the same name in the same directory.
> [<c01f4fe2>] kobject_add+0xd2/0xe0
> [<c02a4e8f>] class_device_add+0x9f/0x2a0 [<c02a5117>] 
> class_device_create+0x77/0x90 [<c02423ff>] 
> tty_register_device+0x5f/0x70 [<c02a5c9c>] kobj_map+0xec/0x100 
> [<c015493d>] cdev_add+0x1d/0x30 [<c02426ea>] 
> tty_register_driver+0x19a/0x1b0 [<c0272e4c>] 
> isicom_register_tty_driver+0xac/0xd0


I saw this same warning/problem in my out-of-tree drivers when the
"TTY_DRIVER_NO_DEVFS" flag went away somewhere between 2.6.17 and
2.6.18.

You need to change this line:

isicom_normal->flags                    = TTY_DRIVER_REAL_RAW;

To:

isicom_normal->flags                    = TTY_DRIVER_REAL_RAW |
TTY_DRIVER_DYNAMIC_DEV;

In the "drivers/char/isicom.c" file.

Scott





             reply	other threads:[~2006-10-18 21:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-18 21:07 Greg.Chandler [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-10-18 22:35 Kilau, Scott
2006-10-18 23:09 ` Greg KH
2006-10-19  0:20   ` Kilau, Scott
2006-10-19  9:02     ` Jiri Slaby
2006-10-19  9:42       ` Jiri Slaby
2006-10-19 10:58         ` Kilau, Scott
2006-10-19 11:01           ` Jiri Slaby
2006-10-19 13:14       ` Alan Cox
2006-10-19 12:00     ` Alan Cox
2006-10-18 21:16 Kilau, Scott
2006-10-18 21:21 ` Greg KH
2006-10-18 20:32 Kilau, Scott
2006-10-18 17:51 Greg.Chandler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E8C008223DD5F64485DFBDF6D4B7F71D020C6071@msgswbmnmsp25.wellsfargo.com \
    --to=greg.chandler@wellsfargo.com \
    --cc=Scott_Kilau@digi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®