mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Hewitt <christianshewitt@gmail.com>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: Sean Young <sean@mess.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org,
	Emanuel Strobel <emanuel.strobel@yahoo.com>
Subject: Re: [PATCH v2 0/2] media: rc: add keymap and bindings for Dreambox remotes
Date: Fri, 3 Feb 2023 13:41:46 +0400	[thread overview]
Message-ID: <EA8F3DCB-793D-41BC-AD02-51677D86FEF8@gmail.com> (raw)
In-Reply-To: <20230203093405.1616564-1-christianshewitt@gmail.com>


> On 3 Feb 2023, at 1:34 pm, Christian Hewitt <christianshewitt@gmail.com> wrote:
> 
> This series adds bindings and common keymap for the Dreambox RC10/RC0
> and RC20/RC-BT remote devices.
> 
> Changes since v1:
> - Split bindings and keymap into separate patches
> - Revise keymap description to clarify non-IR keys and mappings
> - Revise tagging and key ordering in the keymap
> 
> In v1 the RC10/RC0 keymap is incorrectly tagged as RC20/RC-BT and vice
> versa, resulting in some missing //RADIO and //TV keys. Correcting the
> tagging then reordering the keys to match physical layouts [0] and [1]
> results in no missing keys. The keymaps worked, but I've gotten things
> confused when translating from Emanuel's original keymap. So apologies
> for the confusion.

[0] https://www.satking.de/receiver--sat-technik/receiver-zubehoer/fernbedienungen/fernbedienung-dreambox-original-rc10-500hd-525hd-7020hd-dm900-dm920

[1] https://www.satking.de/receiver--sat-technik/receiver-zubehoer/fernbedienungen/dreambox-original-ir-fernbedienung-rc20-fuer-alle-dreamboxen

^ missed these references

> Christian Hewitt (1):
>  dt-bindings: media: rc: add rc-dreambox binding
> 
> Emanuel Strobel (1):
>  media: rc: add common keymap for Dreambox RC10/RC0 and RC20/RC-BT
>    remotes
> 
> .../devicetree/bindings/media/rc.yaml         |   1 +
> drivers/media/rc/keymaps/Makefile             |   1 +
> drivers/media/rc/keymaps/rc-dreambox.c        | 151 ++++++++++++++++++
> include/media/rc-map.h                        |   1 +
> 4 files changed, 154 insertions(+)
> create mode 100644 drivers/media/rc/keymaps/rc-dreambox.c
> 
> -- 
> 2.34.1
> 


      parent reply	other threads:[~2023-02-03  9:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03  9:34 Christian Hewitt
2023-02-03  9:34 ` [PATCH v2 1/2] dt-bindings: media: rc: add rc-dreambox binding Christian Hewitt
2023-02-03 10:13   ` Krzysztof Kozlowski
2023-02-03  9:34 ` [PATCH v2 2/2] media: rc: add common keymap for Dreambox RC10/RC0 and RC20/RC-BT remotes Christian Hewitt
2023-02-03  9:41 ` Christian Hewitt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EA8F3DCB-793D-41BC-AD02-51677D86FEF8@gmail.com \
    --to=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=emanuel.strobel@yahoo.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®