From: "Janorkar, Mayuresh" <mayur@ti.com>
To: Carl Vanderlip <carlv@codeaurora.org>,
"davidb@codeaurora.org" <davidb@codeaurora.org>
Cc: Dima Zavin <dima@android.com>,
"open list:ARM/QUALCOMM MSM..." <linux-arm-msm@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] video: msmfb: Put the partial update magic value into the fix_screen struct.
Date: Sat, 26 Feb 2011 17:49:38 +0530 [thread overview]
Message-ID: <EAF47CD23C76F840A9E7FCE10091EFAB033CD9E831@dbde02.ent.ti.com> (raw)
In-Reply-To: <1298667947-22123-1-git-send-email-carlv@codeaurora.org>
> -----Original Message-----
> From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev-
> owner@vger.kernel.org] On Behalf Of Carl Vanderlip
> Sent: Saturday, February 26, 2011 2:36 AM
> To: davidb@codeaurora.org
> Cc: Dima Zavin; open list:ARM/QUALCOMM MSM...; open list:FRAMEBUFFER
> LAYER; open list
> Subject: [PATCH] video: msmfb: Put the partial update magic value into the
> fix_screen struct.
>
> From: Dima Zavin <dima@android.com>
>
> This can then be tested by userspace to see if the capability is
> supported.
> Userspace cannot rely on that value being left in var_screen, since
> userspace
> itself can change it.
>
Missing Signed-off-by:
checkpatch would give error for this.
> ---
> drivers/video/msm/msm_fb.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/msm/msm_fb.c b/drivers/video/msm/msm_fb.c
> index 5436aeb..bbf841e 100644
> --- a/drivers/video/msm/msm_fb.c
> +++ b/drivers/video/msm/msm_fb.c
> @@ -469,6 +469,14 @@ static void setup_fb_info(struct msmfb_info *msmfb)
> fb_info->var.yoffset = 0;
>
> if (msmfb->panel->caps & MSMFB_CAP_PARTIAL_UPDATES) {
> + /* set the param in the fixed screen, so userspace can't
> + * change it. This will be used to check for the
> + * capability. */
Multi-line comments?
> + fb_info->fix.reserved[0] = 0x5444;
> + fb_info->fix.reserved[1] = 0x5055;
> +
> + /* This preloads the value so that if userspace doesn't
> + * change it, it will be a full update */
Multi-line comments?
> fb_info->var.reserved[0] = 0x54445055;
> fb_info->var.reserved[1] = 0;
> fb_info->var.reserved[2] = (uint16_t)msmfb->xres |
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-02-26 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 21:05 Carl Vanderlip
2011-02-26 12:19 ` Janorkar, Mayuresh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAF47CD23C76F840A9E7FCE10091EFAB033CD9E831@dbde02.ent.ti.com \
--to=mayur@ti.com \
--cc=carlv@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dima@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®