From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969749AbeEXVih convert rfc822-to-8bit (ORCPT ); Thu, 24 May 2018 17:38:37 -0400 Received: from terminus.zytor.com ([198.137.202.136]:47165 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161426AbeEXVie (ORCPT ); Thu, 24 May 2018 17:38:34 -0400 Date: Thu, 24 May 2018 14:38:21 -0700 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [clang] stack protector and f1f029c7bf To: Nick Desaulniers CC: Alistair Strachan , Manoj Gupta , Matthias Kaehlcke , Greg Hackmann , sedat.dilek@gmail.com, tstellar@redhat.com, LKML , Kees Cook From: hpa@zytor.com Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 24, 2018 1:52:16 PM PDT, Nick Desaulniers wrote: >On Thu, May 24, 2018 at 1:26 PM Nick Desaulniers > >wrote: >> On Thu, May 24, 2018 at 11:59 AM wrote: >> > Issue 3: Let's face it, reading and writing the flags should be >builtins, >> exactly because it has to do stack operations, which really means the >> compiler should be involved. > >> I'm happy to propose that as a feature request to llvm+gcc. > >Oh, looks like both clang and gcc have: >__builtin_ia32_readeflags_u64() > >https://godbolt.org/g/SwPjhq > >Maybe native_save_fl() and native_restore_fl() should be replaced in >the >kernel with >__builtin_ia32_readeflags_u64() and __builtin_ia32_writeeflags_u64()? It should, at least when the compiler supports them (we keep support in for old compilers back to about gcc 3.4 or 4.1 or so for x86, but they are intently special cases.) For the PV case, I think we should create it as an explicit assembly function, meaning it should be an extern inline in C code. That way we're fixing the kernel right. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.