From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D71AC388F7 for ; Wed, 4 Nov 2020 11:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42551221F8 for ; Wed, 4 Nov 2020 11:17:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729644AbgKDLRe convert rfc822-to-8bit (ORCPT ); Wed, 4 Nov 2020 06:17:34 -0500 Received: from aposti.net ([89.234.176.197]:49088 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729427AbgKDLRW (ORCPT ); Wed, 4 Nov 2020 06:17:22 -0500 Date: Wed, 04 Nov 2020 11:17:02 +0000 From: Paul Cercueil Subject: Re: [PATCH] clk: ingenic/TCU: Remove NULL pointer check before clk_enable/disable To: Xu Wang Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.or, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20201104071114.6322-1-vulab@iscas.ac.cn> References: <20201104071114.6322-1-vulab@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le mer. 4 nov. 2020 à 7:11, Xu Wang a écrit : > Because clk_enable and clk_disable already checked NULL clock > parameter, > so the additional checks are unnecessary, just remove them. > > Signed-off-by: Xu Wang Reviewed-by: Paul Cercueil Cheers, -Paul > --- > drivers/clk/ingenic/tcu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/ingenic/tcu.c b/drivers/clk/ingenic/tcu.c > index 9382dc3aa27e..ffcb3667fd2b 100644 > --- a/drivers/clk/ingenic/tcu.c > +++ b/drivers/clk/ingenic/tcu.c > @@ -445,8 +445,7 @@ static int __maybe_unused tcu_pm_suspend(void) > { > struct ingenic_tcu *tcu = ingenic_tcu; > > - if (tcu->clk) > - clk_disable(tcu->clk); > + clk_disable(tcu->clk); > > return 0; > } > @@ -455,8 +454,7 @@ static void __maybe_unused tcu_pm_resume(void) > { > struct ingenic_tcu *tcu = ingenic_tcu; > > - if (tcu->clk) > - clk_enable(tcu->clk); > + clk_enable(tcu->clk); > } > > static struct syscore_ops __maybe_unused tcu_pm_ops = { > -- > 2.17.1 >