From: Catalin Marinas <catalin.marinas@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Will Deacon <Will.Deacon@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] ARM: Use include/asm-generic/io.h
Date: Sat, 12 Jul 2014 15:18:11 +0100 [thread overview]
Message-ID: <ED7E6275-79B2-4610-9DA2-CFAC3D026798@arm.com> (raw)
In-Reply-To: <201407121427.22668.arnd@arndb.de>
On 12 Jul 2014, at 13:27, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 11 July 2014, Catalin Marinas wrote:
>>
>> On Fri, Jul 11, 2014 at 04:31:11PM +0100, Thierry Reding wrote:
>>> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
>>> index a78562f21aab..ef54f5c8a7ae 100644
>>> --- a/arch/arm/include/asm/io.h
>>> +++ b/arch/arm/include/asm/io.h
>> [...]
>>> -#define iowrite16be(v,p) ({ __iowmb(); __raw_writew((__force __u16)cpu_to_be16(v), p); })
>>> -#define iowrite32be(v,p) ({ __iowmb(); __raw_writel((__force __u32)cpu_to_be32(v), p); })
>>
>> Aren't you losing the barrier semantics here? The generic iowrite*be()
>> functions call __raw_write*() directly which don't have a barrier
>> (write* accessors do).
>
> Indeed, sorry for missing this. The generic implementation still makes sense for
> include/asm-generic, but arm32 and arm64 must provide their own versions here.
I think this would be the easiest. But the asm-generic/io.h needs some
#ifndef iowrite16be checks.
(in arm64 we missed the iowrite*be barriers completely, so not broken by
this patch; Thierry could update arm64 as well with patch 3/3)
Catalin
next prev parent reply other threads:[~2014-07-12 14:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 15:31 [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-07-11 15:31 ` [PATCH v2 2/3] ARM: Use include/asm-generic/io.h Thierry Reding
2014-07-11 16:24 ` Catalin Marinas
2014-07-12 12:27 ` Arnd Bergmann
2014-07-12 14:18 ` Catalin Marinas [this message]
2014-07-11 15:31 ` [PATCH v2 3/3] arm64: " Thierry Reding
2014-07-11 16:18 ` [PATCH v2 1/3] asm-generic/io.h: Implement generic {read,write}s*() Catalin Marinas
2014-07-11 21:59 ` Stephen Boyd
2014-07-14 9:10 ` Thierry Reding
2014-07-14 17:23 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED7E6275-79B2-4610-9DA2-CFAC3D026798@arm.com \
--to=catalin.marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®