From: Josh Law <objecting@objecting.org>
To: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, "Christian A. Ehrhardt" <lk@c--e.de>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <kees@kernel.org>, Petr Mladek <pmladek@suse.com>,
David Gow <davidgow@google.com>
Subject: Re: [PATCH v2 3/3] lib: kunit_iov_iter: Add tests for extract_iter_to_sg
Date: Tue, 24 Mar 2026 23:17:38 +0000 [thread overview]
Message-ID: <EF4FE426-5901-4068-B484-09AD01068E8F@objecting.org> (raw)
In-Reply-To: <4040556.1774394071@warthog.procyon.org.uk>
On 24 March 2026 23:14:31 GMT, David Howells <dhowells@redhat.com> wrote:
>Josh Law <objecting@objecting.org> wrote:
>
>> if (memcmp(data->buffer, data->scratch, bufsize)) {
>
>If you do this, please do "memcmp(...) != 0". It's not a boolean function and
>the sense is effectively inverted.
>
>David
>
Oh yeah, good catch. My mistake
Yeah, David is right
V/R
Josh Law
next prev parent reply other threads:[~2026-03-24 23:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 20:34 [PATCH v2 0/3] Fix length calculation bug in extract_kvec_to_sg Christian A. Ehrhardt
2026-03-24 20:34 ` [PATCH v2 1/3] lib: kunit_iov_iter: Improve error detection Christian A. Ehrhardt
2026-03-24 20:50 ` Josh Law
2026-03-24 23:18 ` David Howells
2026-03-24 23:22 ` Josh Law
2026-03-24 20:34 ` [PATCH v2 2/3] lib: Fix length calculations in extract_kvec_to_sg Christian A. Ehrhardt
2026-03-24 20:54 ` Josh Law
2026-03-24 20:34 ` [PATCH v2 3/3] lib: kunit_iov_iter: Add tests for extract_iter_to_sg Christian A. Ehrhardt
2026-03-24 20:58 ` Josh Law
2026-03-24 23:14 ` David Howells
2026-03-24 23:17 ` Josh Law [this message]
2026-03-24 20:41 ` [PATCH v2 0/3] Fix length calculation bug in extract_kvec_to_sg Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF4FE426-5901-4068-B484-09AD01068E8F@objecting.org \
--to=objecting@objecting.org \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=dhowells@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lk@c--e.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®