From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2081.outbound.protection.outlook.com [40.107.93.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E45B1E5B6F for ; Thu, 14 Aug 2025 14:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.81 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755182876; cv=fail; b=RZO0L3pxT9EMkGH1rgmhHYNWRcSSaCtb9y8fz2FwcLm0GbSpS7PbaxJ/oaiiDjsqxLkzdVjNtwY5mF3GNsodiY68U73cKNo0Z1SIikbbxPzbUDg7s/8bYXjBLa7qjPhKrlDpeVxH1ys3yQthlNw/Zyz0x48Q4mh/2EJQSW0tK7o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755182876; c=relaxed/simple; bh=+QwOj+BOhGfj8gqmMj3yoAt4la2G4h19V6EVp4CVE5Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=UQEentNSaTjQpkKZY3fCBTSlV8785oenWZ5oYLjtSuIxk7gJKTcZ0X9w1seCc/3tzxnSPGKw+4Gvj3F7duM3qkQnNxkiHJH6IaQP5m8RWy/12bY9q+tDBKBFZ4j8uqf3YdiPdb+DwxhdsQ8cIDezfX3eyUN+rYzoXZAnOJFn/Jk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Ns2OTndW; arc=fail smtp.client-ip=40.107.93.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Ns2OTndW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iQe7onT26a3f9XwrXTvTyOTlGq2qqG1JpLWSBtMEdHmokIhUrzSzjBTTsL94E7IsreUAwXQHEgKT0/Vu3GdEb2OtzKqsM6TGShthfUMZCPYReLC7lcWC/fgN5cee9pZjLvYUKR2r7jJD1yCL0TGgJk+S/aAdifCbB9hDMIrsehlFw5Lq9Nv+8QsBPBQZsiBqxDKI6ZRO2VSApOwzo3b9zHGs7+LfKFSU+HvthtBwWNMqp+Zj+w462Eo1EUSY5wsg1h7PePlkgGCfOfVmmXG56JwmaCmaHVbwaRDKuNVnr3uqTnTAHAofAXvhjEDLhOD2Qs64Ft2pm5sMZWp2nUsc4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zf4PqAOlnr7BD+MW1FzZR5tu1aLCGhAvosH0pHfNb9Q=; b=sHzBh0eXYzff2mW2KkU+QPQgD11l4+MdpbILJPBhaj3QC6+2e/bLgVamFnoP8aUBwn3QLmlrFOF1/bHazhneEhyCABXxyfhIOhlrUUnXENrVlTphn7u+ZAKzO41/9oVJ5xb+sB2/i8u0KIqvoex2GZP5+16TIsw9Q1TmtzGXykCg4R/hGy90blabncN0i9Qo3wFl25gFqbB68gCpR4GitvnVCPMHHK9muDzlwmQcxcnoj05OhMDLRZAcEUKPVpWaY3ArY/ejnIceiLcFSRWNE5LyAMdkXaQzojo41iO8EozMNaNI7FQ/t8sKl+5JXJmyJnh+VgZxZD+Zz2p4zwy5AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zf4PqAOlnr7BD+MW1FzZR5tu1aLCGhAvosH0pHfNb9Q=; b=Ns2OTndWgFmWxe+JWI8wZhAtt8OpoyogLXSa5iuuHU6VApwOG8rcipgyxlgkFPsNTijo3MVx3A/6KaKYzZcwCJJPf9iZl24d7bqXswVBb/3Aj4YtuP5A8WDsEi/e4HbE1N+H0+gjDEtwJn1NPzrBVKOFmDC7Dqpw43MxtOOC8bEU+hQjCdWoi6q+CbX/8WpJYeU33XN4OiM2dpIOG6x3WJ51a11BkyGQg0QuiMkwQH0LiZrTaAUGUUTfJzqWp7ltrCrXxWZ1JUcS3huWqscWzJy/k0puG8sViiIJLObGF5AaYsXWCNpv5GQ7NllW84KqoaoyJfidVQVtnQ7mmf6vnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CH2PR12MB9543.namprd12.prod.outlook.com (2603:10b6:610:27f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.18; Thu, 14 Aug 2025 14:47:51 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%6]) with mapi id 15.20.9031.014; Thu, 14 Aug 2025 14:47:51 +0000 From: Zi Yan To: Ye Liu Cc: Andrew Morton , Vlastimil Babka , Ye Liu , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: simplify lowmem_reserve max calculation Date: Thu, 14 Aug 2025 10:47:48 -0400 X-Mailer: MailMate (2.0r6272) Message-ID: In-Reply-To: <20250814090053.22241-1-ye.liu@linux.dev> References: <20250814090053.22241-1-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0074.namprd13.prod.outlook.com (2603:10b6:208:2b8::19) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CH2PR12MB9543:EE_ X-MS-Office365-Filtering-Correlation-Id: db9bac72-795c-4f53-8d2e-08dddb418b53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dTZQTlZKMGJCYlNvY3Fkc05oaXlnV3hrV3g1WHNFa0RyQTIvenJycTFmWXRL?= =?utf-8?B?YUFWR2ZJZlhFdVNVU2hSYWVvRldLaDd1ZHJEL3dleFJMRzZaL3FQdUc3KzZQ?= =?utf-8?B?c011MTNiNVl5SUx1TEViT3pBS0VSWis3R0ZXdCsxVVBGTkpORzRXcnZyeHhN?= =?utf-8?B?YjMwb2FVS0x3OHgvZGtoTEpBM0l2UWVBMGZGNXpTaENnS05rUnVldVNBNnZh?= =?utf-8?B?Ulhxd3NjbEdUelhsVWltYVNUNVh0b2ZEaElScy91RGxnT0M0Vlc2WnB4YVgy?= =?utf-8?B?WE51eFRaZDM4UFMwbWI1dnZXZklrQ3R1b0FDR2MwbTEyOU41d2hobVVIOTJq?= =?utf-8?B?WGk5TjhzbUhNWTRhaVhBaDVLZjQ4MmlCRExVY0pvODVPVXEyekhSWk1DUDhO?= =?utf-8?B?S3JBd2RhZjNDRkNFcGRpbkZhdDcyOFk4TUxsMGl4WUVRclYwRnZpMVlQa0xi?= =?utf-8?B?ZENtRXNjRjZ3RXdlSnp4RnF4UUJlV0dlY2tHK1ZvSlFMWGhlNC9zbzNOUjJj?= =?utf-8?B?NUNDRUpXT2puK2tTd3NlYW5wMm1vVldDaHJrcUpYQmkvKzJtVVRhbGZkaFVE?= =?utf-8?B?eHdZMlFtTi94ZFQrVTl0eHlMRjlodythY2xhb0FXNHE0R1IxNVdBYXhuUlFl?= =?utf-8?B?S1R5ZzQzLyt5dHg2NUgwdHdiYkhtUWNpZFNYY21hVVFiM2tCRXB1ZGNPUWd6?= =?utf-8?B?S3JiMFdZN1pVdkJxTyt1eVJobytQZ1dqNWc2U242cFNkdEhNbUc0dFRiSFBQ?= =?utf-8?B?dS9PamlBWk5SMjdndUljQWlybXhtVFY3Uk9PZlQzREoyZ012VGlqV01VYS9z?= =?utf-8?B?U20rdFdBc3hkL2szckY4RUpxUzBGSDBOMkJ2TE1MaHFTUE50Qi9qek5RWWRq?= =?utf-8?B?bkRZOTA1OTBndGlNWER3L0lKZm9zbER1UWphM1NzbjgrU0pGQUdYc1RtdW1X?= =?utf-8?B?N3k2czRydjVOYmwxcWtHOTVFQ2pLcGR6Nnc4T3pKY3BEM3NkMFRNYzNreWtV?= =?utf-8?B?YlI3T09SYm5PV2Vic0JzdkZwTW1PN0creEJ6NVNkUTJjTEdZTVpLR1hycGdu?= =?utf-8?B?YWw2aFZKMEFxS0NGNTIzNytML05MZGgyUStkOVJxRE9FV3p3WkRuY2FKSWNW?= =?utf-8?B?Tm5wUUJ5QWxSUkh1M2gweFArZmRtdUFwNnA2UVhZOHNTZ2NEcFZJenlxUE9R?= =?utf-8?B?b0U1TGdlcGJhcWtRa1dtT2l6QU0zdXMzYzdxMWhkMWxKUWFiTkdQQkRJT2tV?= =?utf-8?B?WEtxUjBzOXJsRENOSlJhNi96eldIMzhlVmF1dktLaEVDTDllbFNVb1JTVUNI?= =?utf-8?B?cWlqR0tXUmx6ZFlZRHJWWHdJZWRoZHVnWktPTWFFbTkwQUU0U1hGdmI3VGcz?= =?utf-8?B?dHZnd29IbnhQUnNROVBpZzlURVI0QitlS3RtL052ejdPeENGMlFxcWpuc1I1?= =?utf-8?B?eUk4TDNUaEUzWVYwcXRMK3I4NFc3V1UrVHFhK1crR3pyTEtkR1FTMDlVQ3o1?= =?utf-8?B?YUQvNGFwUTRrT3RRQ0liRnVIOVd2d3hmSzVQS0dFMlljeER1RzdYTzhqQk8r?= =?utf-8?B?d0lXbTdjcXNHbHFHWGR0b2k5U245YXFUMU54YVFVdURsMVJCayt5VWlDeWtT?= =?utf-8?B?eTdKNm9wVSt2SVlpZXhtVXB5dW9hbG5IejBBU1ZxRGJ6cjQ0TXl1bjgrUGlw?= =?utf-8?B?c293SWJFVmdZNy95azdybWlCNTJJR00rNkdIVFAxMm5lVG5tRnhpNFhXM2FH?= =?utf-8?B?L2dXRnIwTkhRWWVKNm9UU1FJZGl2WFU0b05YcXlETXdYcms3cHVYenkxa3l5?= =?utf-8?B?TzNXRUF3UlI1RXpVVEhtMk1HSVNjYXc1U3dmbktJRkNZeVA3UVN3NnVGV2Rz?= =?utf-8?B?ekF2a0lnN2hDRmlSM0JYYzFGdG5QaWM4RmVIWnpBTllUT1E9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGxYQ0dJZWcwalU4V0tPSDczRDNFWkR1WitqL2tFRVMwbWNOeWtPY2tOdmhJ?= =?utf-8?B?UTNYekJ5VEROejdoUHJWVUVuVzhkMnYvYVl2a0NGcjVZVlhoUis1eVoxYkNi?= =?utf-8?B?NEdETVBUSHJsWmNQTER0dXlpRUx1YThrYnQwYTUyK3J1Tzk3ZDJJTnl3Qjlp?= =?utf-8?B?TzBDR01ic3JUam1TQm14SHVvTHpIUFFTMVJjaTY5VWY5NzE4VmxxV3J4Zkt3?= =?utf-8?B?RmJqZDFiOGE0YlhGTDltV1ZSZS9UUHlCWTBxVFk4dUZVK25zSEpPNk4zWVda?= =?utf-8?B?bzFoWlJONFRUeWd5SDAxOEhMUlZoL0JXUEdGelc1eXpLZkJQMXp2K2hJQlN1?= =?utf-8?B?bXM1QjZhVHNBWCtjamljc0NuU0ZYOEJZY1hLc3pTekMxbEJMMi9HcnVkNndC?= =?utf-8?B?Vk9TYzA4WkE2akJacnpBU3grb3RkK253eklDUzNBV1ZmZjVjZUNpVFlDY3Rw?= =?utf-8?B?MEJKb2o5UkcxQzEwekVtK0N6dHRIc09kcW5kNXFXZDRiWmVodXVtU2hDT3Nk?= =?utf-8?B?a0JOSFJNa1BCdTlBd2FleGlEZGlNbUdnUkpqbGhsS25rb2duSGNXdU52amJh?= =?utf-8?B?TTg0UzdvMjJrcXlSaU1RLzk4Z0pDeVI5dTA1eVF4M0sybXk2MUg2MkNFdXpG?= =?utf-8?B?NExRSXRydjFkUTRMTlEvT0Jvdk1ZR3ZaaENyKythMmVwQVJ3WEtNdWVPL1g2?= =?utf-8?B?N28zM2JVUHI2RTkya2VTTzBLV29UVll6bndlZUM2VnNOOE5ZTTk1TmpMZzVy?= =?utf-8?B?cEJrcFFyaU5hQVRhbGpoS21CaEQ2SG1tOTlWNjJ0UC9YazBJcHprY296OGFK?= =?utf-8?B?S1pPWXEyUnpEQjNwdUpuUnUyQUROT3dZTEthMXZ1Y0Y0YkF1ZDNKVmZlK1Nh?= =?utf-8?B?M1pvY1huU2hZOE40VHNsUXhXbDZTWUFlZ0QrS0xOc2paWCthZHR2QUdsUTZq?= =?utf-8?B?Z2dtM21EOU93OGlKT0lLaGs3eXJ0RUIvR2xTVDV6ZFBMZ1k2N2krcUF5VDZw?= =?utf-8?B?TlVFOU9MemlBaGdmc2g2VSszRzUzRmVaYTFlcnhiM3hZWStRUWxITzhYenFB?= =?utf-8?B?TXpYTWdVc2VReW5rMVJnQlBqYkRtL0RYSEJPaWU0UGRwRjFkUEp2UXNsWTdk?= =?utf-8?B?UUttQS9oNUV0bzZmUDF1YVVmMFc0bFIvWmZTOUtxVmVaL0dhbUVxNG9CMjhw?= =?utf-8?B?ZUtMcTJrRjdxZ0ZtRnVmVUlMYUZvZFhERytGWjMxanBOckhQd3U4YU1leGhL?= =?utf-8?B?RmR6cW51R3RVMEFUUVl3RU5Ubk11RGxRdWpZaDZBUFJRamRWQzF0T1hSQWxY?= =?utf-8?B?cEF5SnZObGYwblh1THczejlrV0QranZiemZXYW5QL2tKZGdNNVlubmhiODZ6?= =?utf-8?B?YjlBTUU2SWRqMzVXN0hvY09NUG53VUVVU0p5cVJLdFhxUVJhSS9zRlZidVEy?= =?utf-8?B?NU1FZkVlbkpaRVY5aVora2JzV0dydG1tUDg3cUpaSzA3ckpXczUxbG5tbHJZ?= =?utf-8?B?a2pGcjZjNmhwS3hoZkNtQXJDdS9WazNiZ3BkOWtEUzhibDU2ZFpyL2dZV0ZL?= =?utf-8?B?RG9JcForREtDVXNlTjAwbDErY0lpNnYwZ0p1MG1FTnJ1UEJpQzRoa3Z6Ymow?= =?utf-8?B?VjZGQ3FxMzV0Z2xWNmw3OTkzenplSjBYUkt6UkVzcXZFV091NFBSckpWRlNh?= =?utf-8?B?Z0R0YXFnQklLN0c4Z1hxVlRwTndpU1dsZ0szVUxXMmg3ODNtTFlDUXRvRmFR?= =?utf-8?B?eG5tOTdpVCtFWTVKQ1N6SC9XYmN2N1orS2JxUFdJTkNOTDJHR3NBRmEzcWhP?= =?utf-8?B?bUlGS0hUbWl0OUl3TVJSVStQWHVKNVM1aDhJUU9kellUTjZBSVQzZE5wZCtT?= =?utf-8?B?Sk9OcE9RT0llYlZDK0VDeDFpUThZY01HaVRCMUZHK0tRRWptRndFeG5FcTl0?= =?utf-8?B?TWNiTmxJWDZEUVJQWmVlZVlPWkpGVnBoeUZVSXRia3EvOUFmY3FlZDVBTHVT?= =?utf-8?B?bWdKMmRNTWZlbWk5L2ZpUkVwZGdsM1hvZ1NuWW4zNi9CT2xYbmRsaFlySWxC?= =?utf-8?B?MTNlL3R4TXVPc3RSWUovbU80U1kyTFFEWFpqK3BWeWJaa3ArbXhxN3FMN1Bn?= =?utf-8?Q?NMnb7xPc6Ca8fGxGzULNTVDr4?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: db9bac72-795c-4f53-8d2e-08dddb418b53 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2025 14:47:51.4461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0/EKIHGd0FUhmYFVnPE25HF5gzrBJvkqpcsaN1a8CTH2UbtqiZMM9zeRf9f3Cg4z X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB9543 On 14 Aug 2025, at 5:00, Ye Liu wrote: > From: Ye Liu > > Use max() macro to simplify the calculation of maximum lowmem_reserve > value in calculate_totalreserve_pages(), instead of open-coding the > comparison. The functionality remains identical. > > Signed-off-by: Ye Liu > --- > mm/page_alloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 64872214bc7d..8a55a4951d19 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6236,8 +6236,7 @@ static void calculate_totalreserve_pages(void) > > /* Find valid and maximum lowmem_reserve in the zone */ > for (j = i; j < MAX_NR_ZONES; j++) { > - if (zone->lowmem_reserve[j] > max) > - max = zone->lowmem_reserve[j]; > + max = max(max, zone->lowmem_reserve[j]); > } There is a “if (max > managed_pages)” below. Maybe convert that as well? Feel free to add Acked-by: Zi Yan . Best Regards, Yan, Zi