From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757183Ab1K3Bs1 (ORCPT ); Tue, 29 Nov 2011 20:48:27 -0500 Received: from gate.crashing.org ([63.228.1.57]:45976 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661Ab1K3BsZ convert rfc822-to-8bit (ORCPT ); Tue, 29 Nov 2011 20:48:25 -0500 Subject: Re: [PATCH v2] Integrated Flash Controller support Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <4ED5531C.6030104@freescale.com> Date: Tue, 29 Nov 2011 19:47:46 -0600 Cc: , Li Yang-R58472 , , "b35362@freescale.com>" , "linux-kernel@vger.kernel.org Kernel" , , Andrew Morton , David Woodhouse , "linuxppc-dev@lists.ozlabs.org list" Content-Transfer-Encoding: 8BIT Message-Id: References: <1320053901-23801-1-git-send-email-b35362@freescale.com> <8EDB3DC6-63E5-4D5C-BB52-15F32B85C5DD@kernel.crashing.org> <1322602860.2150.10.camel@koala> <4ED5531C.6030104@freescale.com> To: Scott Wood X-Mailer: Apple Mail (2.1251.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 29, 2011, at 3:48 PM, Scott Wood wrote: > On 11/29/2011 03:40 PM, Artem Bityutskiy wrote: >> On Thu, 2011-11-24 at 08:24 -0600, Kumar Gala wrote: >>> On Nov 22, 2011, at 9:41 PM, Kumar Gala wrote: >>> >>>> >>>> On Oct 31, 2011, at 4:38 AM, wrote: >>>> >>>>> From: Liu Shuo >>>>> >>>>> Integrated Flash Controller supports various flashes like NOR, NAND >>>>> and other devices using NOR, NAND and GPCM Machine available on it. >>>>> IFC supports four chip selects. >>>>> >>>>> Signed-off-by: Dipen Dudhat >>>>> Signed-off-by: Scott Wood >>>>> Signed-off-by: Li Yang >>>>> Signed-off-by: Liu Shuo >>>>> --- >>>>> arch/powerpc/Kconfig | 4 + >>>>> arch/powerpc/include/asm/fsl_ifc.h | 834 ++++++++++++++++++++++++++++++++++++ >>>>> arch/powerpc/sysdev/Makefile | 1 + >>>>> arch/powerpc/sysdev/fsl_ifc.c | 322 ++++++++++++++ >>>>> 4 files changed, 1161 insertions(+), 0 deletions(-) >>>>> create mode 100644 arch/powerpc/include/asm/fsl_ifc.h >>>>> create mode 100644 arch/powerpc/sysdev/fsl_ifc.c >>>> >>>> Guys, >>>> >>>> How are we handling this patchset since it touches drivers/mtd/nand? >> >> I do not see it touching MTD from the diffstat above. I am a little bit >> confused why a flash controller is added to >> arch/powerpc/sysdev/fsl_ifc.c ? > > It's really a bus controller, with NOR, NAND, and general-purpose modes > settable per chipselect. The actual NAND driver goes in > drivers/mtd/nand, and is apparently in a separate patch (probably due to > separate maintenance domains). > > It's the same situation as arch/powerpc/sysdev/fsl_lbc.c versus > drivers/mtd/nand/fsl_elbc_nand.c and drivers/mtd/nand/fsl_upm.c. > > -Scott As Scott said, I was more asking about the 2nd patch in the sequence which did touch MTD. Since that one is dependent on this patch, wondering how we wanted to handle them. - k