From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07142C432C0 for ; Fri, 29 Nov 2019 19:22:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7FFF21721 for ; Fri, 29 Nov 2019 19:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbfK2TWi convert rfc822-to-8bit (ORCPT ); Fri, 29 Nov 2019 14:22:38 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:59120 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726926AbfK2TWh (ORCPT ); Fri, 29 Nov 2019 14:22:37 -0500 Received: from [192.168.1.91] (p4FF9F0D1.dip0.t-ipconnect.de [79.249.240.209]) by mail.holtmann.org (Postfix) with ESMTPSA id 923A2CECDE; Fri, 29 Nov 2019 20:31:44 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: Re: [PATCH] Bluetooth: btusb: fix memory leak on fw From: Marcel Holtmann In-Reply-To: <20191129173635.87479-1-colin.king@canonical.com> Date: Fri, 29 Nov 2019 20:22:05 +0100 Cc: Johan Hedberg , Sean Wang , Bluez mailing list , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20191129173635.87479-1-colin.king@canonical.com> To: Colin King X-Mailer: Apple Mail (2.3601.0.10) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, > Currently the error return path when the call to btusb_mtk_hci_wmt_sync > fails does not free fw. Fix this by returning via the error_release_fw > label that performs the free'ing. > > Addresses-Coverity: ("Resource leak") > Fixes: a1c49c434e15 ("Bluetooth: btusb: Add protocol support for MediaTek MT7668U USB devices") > Signed-off-by: Colin Ian King > --- > drivers/bluetooth/btusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel