From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-122.mta0.migadu.com [91.218.175.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 285523F7882 for ; Thu, 20 Aug 2026 09:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218763; cv=none; b=KDTIIjiMun5fYhy0jlGxU3kYQkIdDWwaVr5CFaOhyRZjSE4TGK3QYtnjqZR70lven+5mmKK9o/MWVHYmJI+AH27XECI6vXnL1TtyacnJTvCcaRUOUpyzDJO72top5Vce3V+UEmHh6KNoU4b1RQ2m7iT2CfOBdWZksWfxE9DSrek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787218763; c=relaxed/simple; bh=7DsDg+FFQHE0daJt3tXS4ugvHiwFdRCRdfz1HqtMZc8=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=KqbqteXmVo/KaS4//sLl/WYu3IMJ8ovOmt2D/jvCWyG+sxAfs4pzT06RtQDQ38O2H3qd2bnr342tyky5MQFXMK19efQbCI5z29g+Wknvg+mwNJ3VFnItVL7/ZDTjh/x2lfHVYZ5G1j8lyUh0z7dbPNy4MIW97WjjopN9xVqjiMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=OhgkQRHZ; arc=none smtp.client-ip=91.218.175.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="OhgkQRHZ" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=7DsDg+FFQHE0daJt3tXS4ugvHiwFdRCRdfz1HqtMZc8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787218755; v=1; x=1787823555; b=OhgkQRHZ5pnEcVrPUAcvUR98apJqLVvmPLwtxMZnm9iRWC4bHclyl2VW+vwFZhtVzx5hOXXL Ps7fVxkW4Qc0lu3suFu1My6TD2ocRj57G5180Gj8fGarim9Obz1LDnVywJLXvj9NFtpxE0rPrwr QqrJi7j1W6LpomBhTDV13SWw= X-Envelope-To: linux-kernel@vger.kernel.org Received: from smtpclient.apple (2408:8606:1800:501::1:7) by mta12.migadu.com with ESMTPS id 093084cf8ca96627; Thu, 20 Aug 2026 09:39:15 +0000 X-Mizu-Trace-ID: 093084cf8ca96627 X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH 1/1] mm/hugetlb: do not dissolve gigantic pages without runtime support From: Muchun Song In-Reply-To: <206cb1f2-b66c-4b7b-b0ad-14cca9d8e0bd@kernel.org> Date: Thu, 20 Aug 2026 17:38:58 +0800 Cc: Longlong Xia , osalvador@suse.de, akpm@linux-foundation.org, mike.kravetz@oracle.com, mhocko@suse.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Longlong Xia Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260817162039.1511838-1-xialonglong2025@163.com> <206cb1f2-b66c-4b7b-b0ad-14cca9d8e0bd@kernel.org> To: "David Hildenbrand (Arm)" X-Mailer: Apple Mail (2.3864.600.51.1.1) > On Aug 19, 2026, at 16:52, David Hildenbrand (Arm) = wrote: >=20 > On 8/17/26 18:20, Longlong Xia wrote: >> From: Longlong Xia >>=20 >> dissolve_free_hugetlb_folio() doesn't check = hstate_is_gigantic_no_runtime(h) >> though remove_hugetlb_folio()/update_and_free_hugetlb_folio() = silently >> bail for such folios >=20 > That's odd. Why do they silently skip such folios instead of warning = that > something unexpected is happening? >=20 > This screams for a cleanup unless I am missing something :) Hi David, Sashiko actually has a pretty detailed description [1]. So I think it = deserves a fix. [1] = https://sashiko.dev/#/patchset/20260814083027.1419487-1-xialonglong2025@16= 3.com Muchun, Thanks. >=20 > --=20 > Cheers, >=20 > David