From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755398AbdJISe2 convert rfc822-to-8bit (ORCPT ); Mon, 9 Oct 2017 14:34:28 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29790 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754162AbdJISe0 (ORCPT ); Mon, 9 Oct 2017 14:34:26 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free() From: Kyle Fortin In-Reply-To: <20171006222629.GA30627@debian> Date: Mon, 9 Oct 2017 14:34:18 -0400 Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.levin@one.verizon.com Content-Transfer-Encoding: 8BIT Message-Id: References: <20171005180920.GA121296@debian> <20171006222629.GA30627@debian> To: Tim Hansen X-Mailer: Apple Mail (2.2104) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 6, 2017, at 6:26 PM, Tim Hansen wrote: > On Fri, Oct 06, 2017 at 01:04:25PM -0600, Jens Axboe wrote: >> On 10/05/2017 12:09 PM, Tim Hansen wrote: >>> mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks. >>> >>> This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch). >> >> Applied, but I had to fix up your commit message. Please line wrap at >> 72 chars, otherwise it turns into an unreadable mess when people >> try to view them. >> >> -- >> Jens Axboe >> > > Noted! Thanks for the heads up on the char limit. scripts/checkpatch.pl would have caught it too -- Kyle Fortin - Oracle Linux Engineering