From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012056.outbound.protection.outlook.com [40.107.200.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 383A1373BEC for ; Thu, 16 Apr 2026 20:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.56 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776371427; cv=fail; b=uG+nKmYkRVJsHnfQclYoxwfy8xH3/n52Va4p2JPiuyhZB0/b5KJtOC7wU6HaHuFwCW1Q61SafWz+Ra7mNFUn1XASEkRa1AcfpyrDT1Z12xGJPcwE3425x9tBxW4MpitmL1WLO62skY+rogZTVOIIt7lrsS4+kLxVmdknH4nRZjY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776371427; c=relaxed/simple; bh=+mQKyD2pjBMh5MSR/8j41ETf2O+d7qGFzMpbordITVk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=B+shV68RZWvx60c9p8xJJ4wITGf0SrE6nqQwX1JmEv0KodYLwStMO4R5mOtpEHAU+dlmzGpu1LDp2K9Ox3r4flZXLW8t2P2mL9znP6RKoippcel+N4TLQJgYIFMk2LYiTqqBiZk1FXx65+m3i21R8KSPShPRuZO9C//+H7q8Rrc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=LfZNdSU0; arc=fail smtp.client-ip=40.107.200.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="LfZNdSU0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OYY+nkxBMxMfhMQzva2UjkPi06L81hvEPlUsHAovP0pOtdChZjCLVuRwNu3GJl0y0GwHlC5FsQnPVRS/iMMq4p4BQ/WsLHT/QJekAvFP3rtsTgRqzwVF5SvIrJ/hcuphCv0CIV3YFYlWv38ExbpK6vcd2waQfhQJi/dUHtP6490PO7GxwvSiza5TYzXGKOWlHcukzLRRJHxbtSn3GiCM1CHxNS1C3k9Lsobw2ySHyvN6tnWS2MYCVuQcdUTPaXCb8I23QEq1lgxKKwXKv5zbT/ms3J7JYA0HwrHFa4aw7AUPJN0ZVOufkWN+9alp8ybL3FsJ80FiPi2Q6jXlgyZnqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VsfDljdVp4FmAj0zexoOHXGaEexDd9av/t1cEUNF2I4=; b=xn9elGtaFj9nEiMBO3r+ZawwWZyO+ekns3/N6plWchPIMQlw5nhlHiyslgYM75nhp9Z1DeFvG17MxPulhr9oEjMio63iK+/NjA66eVOFTnFERIabyK5QV0VSrf95tVZax9uaAq2CzOURg0gZfzAPX9W7bMuUJG0BsfHnBf6SyG4gd48dpePPBkgZjPm696VWoMcrV4d6nqEWHr4GYE12XLJ4DseybdmZQCnr1kWzBrHke2QctT9T+JMWiZfzsCxbVErVJbRkWd3RVIqq74MR7feYKZMrLgDyDqBradlu45PipjcyCJko7qeTShs0LpANA7RJoPUBObu0s95rb06mdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VsfDljdVp4FmAj0zexoOHXGaEexDd9av/t1cEUNF2I4=; b=LfZNdSU05R6WtCb1p/btOFtxLKJkNTqKMb16bKsytFflpGQKvKvINDi4w6BMbqz/f51FzcntA4wLa9trpweEVve313CdhKhB6rpLzlDyfwLNnwT2EnUm89iwVoZ/B3WnGCJbZFRNtk7NocLgPhEjEOgjpPE6qnqszE3TXVp1II/poXkkWkjho9WpjFnl01hUcjQd18l4/HxOY9yIi9BkAeMymGXZH5WqIrF3ibF6417rZF+SgyU4YAdIOD1SeC28uoPuXcozDFeb40QT3X7V34QIpktpj/WqLX2a9xwmjg6wZNB+Xopw9zqhxdqtf0v2hwxMN4pkRUxWNhFb2/Nlvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DM6PR12MB4235.namprd12.prod.outlook.com (2603:10b6:5:220::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.17; Thu, 16 Apr 2026 20:30:15 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9818.017; Thu, 16 Apr 2026 20:30:15 +0000 From: Zi Yan To: Sunny Patel Cc: David Hildenbrand , Andrew Morton , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/migrate_device: Cleanup up PMD Checks and warnings Date: Thu, 16 Apr 2026 16:30:12 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: In-Reply-To: <20260414141344.29949-1-nueralspacetech@gmail.com> References: <20260414141344.29949-1-nueralspacetech@gmail.com> Content-Type: text/plain X-ClientProxiedBy: BL1PR13CA0126.namprd13.prod.outlook.com (2603:10b6:208:2bb::11) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DM6PR12MB4235:EE_ X-MS-Office365-Filtering-Correlation-Id: fcc64bd9-7dbb-481b-ba71-08de9bf6f797 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: AZJuPa8d1x2WCBuwcJiBHd0KI8VesSPS+boz26Tc+G/5umckyURlANO8HzxGfX/Fuuli+YD/AlOH2B2xx0Rtq5OfMQsf3rHYOYaMMlXfYBpVJHiG+NOKA5c9qLeqBSKP3XgCiX60bSUJRauEmkCih6Sd6efW06R+My/haPJqs+bSnBZMJlrytqmXIec2NkQLcujEt9OmQqgRJ0ZEcILHYvdUIekjpJxo2MPGOjDbkfeOY4zGc8e9UOo40dLKg1HtxUk49wMZZQjrZH7UhBheHxcldcEfEy1+sXgXZB5XClFurUAIJHmxe1Js8Lu5ZRd1cYb3UO3FYfwtbEyPqsnwNSWyfe7GPCrVKaNQfUTHVcKMjnNkZ9OALRmmPqcP/YFEmNam5kPrDnV+cfEnJPK/HcrNGTRmOtxyxshvPn5JKspY4UFfh5Hg2YY4AmkQFkK+EbGSRgle0QGgruIb339o/ENc/ug6BBaQgfJlkOfhWGR7zquvXNgmQclDBTnYjJYwM6Xn8NljicEk59A0JQJ94bj7ErBmMJN/79sJrzYLqmU/ofBn4Xvw6SP3Ubr9r3jyk0+5JyIpi/UCGspNmGbA3MtMwXEL0tnn4ks+845rg48Xsnls2bgPCIcNw4/5LwPUOwGTI0f+Xze+wFlU9dnKhqc+NBVVk8ukfBt8u3C8yGXke7vfEwScdGaKwNTabkiAdbVceXwdTvFRLZ8iR1up9t4yGG+3HCzqb4UpfkKyGl8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RkxK+I+igBPuqxLiB9deUseEbOmAZqTulkMCDVrsdKriRyyY4SCqsByyQKv1?= =?us-ascii?Q?m/VJJmbtF/cdkqOAi5fJtjeI315Yj6ufvNTzsRTTqetfmBybXkSWbUuW3ovQ?= =?us-ascii?Q?Vu031O8bYNjih4s0Zxt9d2wqeU6vBvvrNid2NPQZpGnsz5Xx/pUcUxkAyS/I?= =?us-ascii?Q?ijWPc5py3jTDdeSfHcmxYsxOUlUfNdQ34UQLQ/XmO5Ki1boEcyucXXDVw2rL?= =?us-ascii?Q?+QzkuWUsauKMsvFDug37vfTt2C3HXtVtatrNTiVc9Owf2PDcfQLTu0j59YSH?= =?us-ascii?Q?6JLjJOjWZVAtJg7ZWKqYYPd7fdkal0qMAFPYcsYnaCsHiB4cxkUQixY4SpR8?= =?us-ascii?Q?94P9lhlxOJ7BN/at+0joTIj5LMEiCrEIlG2DC2F4uHLKo0C+YLgcGoYA9rA4?= =?us-ascii?Q?tV9PhJrri+9D06zYfTBeZpJ1S/doH3k/OOIZASO70fgNZhZ2u9OReFFm0dUv?= =?us-ascii?Q?oEalPV93t8P6n3TMg6r2adGsiUnv5KbmOrtNE9ZkjtR5n1+mdaOfD3aV+/c1?= =?us-ascii?Q?ZIphOLFRd2jPYqwZd3QHztUHYTsMUr7suqSaPvTDDrLKbShZkK96v0lX2shW?= =?us-ascii?Q?lGZEpoLFAlmET9l3o+cuFWtHOmMxPDbczNvlchind4vQLnyeXNGDzU5qOsBZ?= =?us-ascii?Q?tEEsRq4OD7MEAlX9Z5vDu32HYzQhbnxsHJtgNLtTmZa0IZWIH83W1CLVBn8J?= =?us-ascii?Q?iHdYi8c0AHcxxkr4FS+nSgSA19dpKt5JFSewgBXXKfMF3i8T2gmX95MIHIVO?= =?us-ascii?Q?c48cKLmv6x0xUDqedIPT0wAbhCqZYllwakBw/eJZso4OprujenZOJxK8m/Zm?= =?us-ascii?Q?B6IeSgYNpwxAtCD47SP2FtP+w0enexlHT9HyJTgz7jSvSz4JpS3Sj7JQVG41?= =?us-ascii?Q?QA7OWqSbu5XErkfj1TnDrrPvuK9AXSTrWb4g4OxqgsiDErsivrp6aHCJA4ar?= =?us-ascii?Q?qZ6MYqywA8uuiXWFOo2dUheWVkjRxerYFWOe4MmzD7s2wk+IY2dB79m6BFKQ?= =?us-ascii?Q?rVcgOzMsJ6vV4vdLWcOlkSiYyMOZI6H0Q1XpGMuZMM/nSLtnFUIFYQ132/kW?= =?us-ascii?Q?p1swCSBqOF3VEchKIl1+vT7O7YmWXC6LHQaux2H/xG28YbwaTvYeYXFkdVB6?= =?us-ascii?Q?m1k6NZau3KqknkDiyDwE9n6y9uK4iRc94FB7KzeEhrlHV9Jb76Voc9pf7jpj?= =?us-ascii?Q?vcWXire+8OaHKqwdaMIZuzMEY4XtKQBP96x3JhqQKtoHWcl2XokTFFOG1CNx?= =?us-ascii?Q?k0M+xmE1bosSJSyOTEqpZLlNeEg1U+6j5IfIueGwSa7f50uR+LXmU/t7DoxN?= =?us-ascii?Q?Eru/1ySZd3TVmfUjSSGeR3mZ61YYYItcOPyMdUi0K01/NG9wJOe0Qk/NAazz?= =?us-ascii?Q?/CBoBrb9Q6NQsrVi2T4BNw9Cj9ORYAqW9Lj+Alm876vdOUMTaDTOrxidC9q8?= =?us-ascii?Q?AdnGnR2lA6bCcwF2FB5FNWoNMSYQN4CfuNO85K0qIf0gnEm0JhuOkq4ppVq9?= =?us-ascii?Q?yWwogo0yTZaXGt4Ba0kGw3qm5HTMCnjmZAVMR6Eh6ZD8lZxCkHuUqQ6QXiXK?= =?us-ascii?Q?hc8eoV72sXnfSnKshufp+SPCGetrWI1nrEQHvNJ4lij2zoOiQ6NMrTXYaumO?= =?us-ascii?Q?cfEhqGA6Vfu+nS+vc6I/BsH5XzCnm0i3Aa6dKvoxZ5NkPoR9JY22NPkTRPAW?= =?us-ascii?Q?vaffiYoyB7SKs/vpb0TwsNAUrzl6aTeG+BrJCDdyEV1XmIu+?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcc64bd9-7dbb-481b-ba71-08de9bf6f797 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2026 20:30:15.2624 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cGh8RxeL4OOzhmsQz9NuhD/X8l2ssbUcAMbgneTj88mzrNuYRJ6NCXw2jbLvHde5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4235 On 14 Apr 2026, at 10:13, Sunny Patel wrote: > Remove the odd VM_WARN_ON_FOLIO(!folio, folio) usage and replace it > with a simpler VM_WARN_ON_ONCE(!folio) check. > > Drop the redundant VM_WARN_ON_ONCE(!pmd_none(*pmdp) && > !is_huge_zero_pmd(*pmdp)). > > Refactor the PMD checks to use pmd_present(), making the control flow > clearer and avoiding duplicate condition checks. > > Signed-off-by: Sunny Patel > --- > mm/migrate_device.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Acked-by: Zi Yan Best Regards, Yan, Zi