From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdJYW0k convert rfc822-to-8bit (ORCPT ); Wed, 25 Oct 2017 18:26:40 -0400 Received: from mout.gmx.net ([212.227.15.18]:60855 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbdJYW0h (ORCPT ); Wed, 25 Oct 2017 18:26:37 -0400 Date: Thu, 26 Oct 2017 00:26:10 +0200 User-Agent: K-9 Mail for Android In-Reply-To: <20171025185349.ocptudim3g35j6im@linux.intel.com> References: <20171025134438.vgh6tzkups2tujps@linux.intel.com> <20171025185349.ocptudim3g35j6im@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: Fixing CVE-2017-15361 To: Jarkko Sakkinen , Matthew Garrett CC: linux-integrity , Kari Hiitola , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Alexander Steffen From: Peter Huewe Message-ID: X-Provags-ID: V03:K0:+mTH8o3MI+1Is2FDO4m5FRfISjVSZhH/1TZxlWgy1E2IxGZJ04S 05ljsDRzUUADAFUhMZtibkxGsNitEAc7k/nv/if9BQWmlYHDSIf5H2OgpRc9oqu0vsn/3yp PlWlPeNCa8fWq4fqpzFnq1X/3H+TNLsUHGIfBSVLRSFyffMIY2+e/FS1scyPLQEYBcofwQk IfVe760heMs//LTVH4yXQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:GVUO2aeOi9A=:T/qw9Uw8/iIGbbDhIiiWPl tEtGzOSC6Gg64IvLkZ+bApSZeb/px4G9XwXAV+dizEX8JrrsVkQX3S6ke8u8vkwfZ0rccDmGA NBHQraqyWIoMw+zJYrdCe/a9fWHFM0ZXNduh6AEnnox+VUh/fTpxdj4EwzumhvfqdW0BZq92T HZHtw6ZfQbDbfJkyovnSQhI06Ae6qk1NC9YBBm/Vvw2VferYSKyln4G9Q1GyGL9LXCdok4Yi4 5w+ZQ99jqcWxWk5+KSdkhITlbSvBBQtFQMW0kJ0rjhZd+0f7kUpxeaAXCTgeFQAjug2y/sQtg hX1ddXxYn0/mCkR70Z0BOyDeOoM1zzsG1VhBMwS4GejaDweCRXG2urQMtNhg4wFzVT+BlrrlO LwpJpdKyrF0eo2WVY3NblQ7oOmRda5wVEVbM4iVs0YUJGAvliZPUxgPv733CTuwqT07r5qo82 xlVtap58Sf80OIrKiRECsa7dm9PjN8bEgh0mQZuU1oUYyJdPyR6qGc//SwdCFxGFkt2v0ickn CMz5C1OfczEJZTz4AzApm1PobcFYZGuyAEEtzraOIvVIQYr4eWlxRSaifSMnp7SlrOwTkByQe AEJ5nSaskyMzbb67Q20tWNrTkfDFlZzyvrKGSA/Kf1IvUUQK16bfrKEutxcI2/AbjRzFk/jFM CtW4nwcvVxcn1tSlPYIKiMF5/0ywf49iMqxAS7qHHA8rbxdJVfGXrEl0w3miXS02STQKhS0oB S8Vq7X697HsT1Ls1uR+X2Q122vosWWqKNthxsgwYZ0kswUAihegjiFOVsylsKqWxFa8cZeTY9 daZo57ipNSJhdksTe4SwOjP9BzZWUPFDOE1V7/It4Q31sJK8EQsk04fEqwooQl3CNwn0r/1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 25. Oktober 2017 20:53:49 MESZ schrieb Jarkko Sakkinen : >On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote: >> On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen >> wrote: >> > I'm implementing a fix for CVE-2017-15361 that simply blacklists >> > vulnerable FW versions. I think this is the only responsible action >from >> > my side that I can do. >> >> I'm not sure this is ideal - do Infineon have any Linux tooling for >> performing firmware updates, and if so will that continue working if >> the device is blacklisted? It's also a poor user experience to have >> systems using TPM-backed disk encryption keys suddenly rendered >> unbootable, and making it as easy as possible for people to do an >> upgrade and then re-seal secrets with new keys feels like the correct >> approach. > >I talked today with Alexander Steffen in the KS unconference and we >concluded that this would be a terrible idea. > >Alexander stated the following things about FW updates (Alexander, >please correct me if I state something incorrectly or if you have >something to add): > >* FW update can be constructed either in a way that the keys in the > NVRAM are not cleared or in a way that they are cleared. >* FW update cannot be directly applied to the TPM but must come as > part of the firmware update from the vendor. > >I proposed the following as an alternative: > >* Print a message to the klog (which log level would be appropriate?). Info? Maybe warn, definitely not err >* Possibly sleep for few seconds. Is this a good idea? Helps how? > >While writing this email yet another alternative popped into my mind: >what if we allow only in-kernel use but disallow the use of /dev/tpm0? >You could still use trusted keys. > No, same terrible idea since you block the upgrade path. Upgrade tools work from userspace via the kernel driver. So /dev/tpm0 is necessary. >Here are all the ideas that I have and I am open for better >alternatives. > >/Jarkko -- Sent from my mobile