From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Akhil.Bhansali@hgst.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [patch] skd: remove broken discard support
Date: Mon, 25 Apr 2016 19:54:54 -0600 [thread overview]
Message-ID: <F2A47426-9037-40D6-AF24-F41ED63F1F98@kernel.dk> (raw)
In-Reply-To: <x49inz52vie.fsf@segfault.boston.devel.redhat.com>
> On Apr 25, 2016, at 4:06 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
>
> Simply creating a file system on an skd device, followed by mount and
> fstrim will result in errors in the logs and then a BUG(). Let's remove
> discard support from that driver. As far as I can tell, it hasn't
> worked right since it was merged. This patch also has a side-effect of
> cleaning up an unintentional shadowed declaration inside of
> skd_end_request.
>
> I tested to ensure that I can still do I/O to the device using xfstests
> ./check -g quick. I didn't do anything more extensive than that,
> though.
Applied, thanks Jeff.
--
Jens Axboe
prev parent reply other threads:[~2016-04-26 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 22:06 Jeff Moyer
2016-04-26 1:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2A47426-9037-40D6-AF24-F41ED63F1F98@kernel.dk \
--to=axboe@kernel.dk \
--cc=Akhil.Bhansali@hgst.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®