From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88ED811CBA for ; Sat, 21 Feb 2026 21:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771710724; cv=none; b=sf5XP31ZEF9U8Of054cI0DGD2bmgeI4gKvgkpLHgZ/vpI6POgH7vvMB/1Qlpo4vLtalkEV1uau8Hw8gJje5UJfm1OdQ3rdSzPUToxE05csiSzU0m0Yz6pXJ8puHD23zB7GTDu7D9R44rlPcFL+K4rWlekuBpPffKIMhqPdECM0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771710724; c=relaxed/simple; bh=5nG6IxRdYMtDn2Q9JpcqhAyZTV8BhE0+6rzpe/dzGU4=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=fKrMpD+acKH4cD4hfynduP1PCa0Z+c5P/KWQKONcBCI27WncuJqfALIp2tEGMjxqiMgUCpyv8gXJ5N96XwwAKkUuVcdiZzJMZkbeWw8DDcsN6Is2r96vJx6BjuR8kf7PeyAFBiTGjsuOsYSr4IGxNp0224z6x6JBVlUXa8H+zY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ShF5Gxwd; arc=none smtp.client-ip=209.85.222.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ShF5Gxwd" Received: by mail-ua1-f68.google.com with SMTP id a1e0cc1a2514c-94a231b285dso1711416241.1 for ; Sat, 21 Feb 2026 13:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771710720; x=1772315520; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5nG6IxRdYMtDn2Q9JpcqhAyZTV8BhE0+6rzpe/dzGU4=; b=ShF5GxwdGL4Ldq7F2qh/f8Jt8+PzKfU78HNOlr0trilr2LHRJHgpM5TXH4OGYE9Gxb v5AwxQeSZaW4CaGA0+ZOazsVPLxzMxyZmodmjmjY6/eZlJ8XeztBzsm56DMeNxA8dMBq E1qfvjS9RksAOJ29gr+Z2EdJ1sVfrKeDapjCbyLjn1pqNuZcB64Mm5d8MCacrEXgxsxP A6/tmjgf+aOqncAtG7NItkFcHwuVsBZdcvbl8rmwfUznfxJKjRe+4AYp9CVQF15Lb1M8 BvjrTERIUUiVyxEaYfAXXgwFyDNmL6IDAqOE10c2y1pSObUIVj9KgB44ehDYQdCChsr4 ub/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771710720; x=1772315520; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5nG6IxRdYMtDn2Q9JpcqhAyZTV8BhE0+6rzpe/dzGU4=; b=OPnOofE8CxsNXGMSUkyug7rPxH+dL3skFJ/D7dawHuXJiqpPlZpndPeIauLcfvaHxd c/DbhHR1AXzzdLoaWAcjf1TtnVTW0C4XpUnwabs1hr7LQlJTlXbL/H80BuKGrgfHbvPU BKxfJXM9FPnKxOOOIXVz5YgN+zVgGCjcHK+D8Ypce3P1rIhTAlM0avGcHmq5bdAQWp+2 1kekKE+y8jMX53Frv5Oue+e2DXsiXWsvx9rlubTogos74pggLfHD5L7+ktTKwUHj5TJr wSnbDIfF72QAIbfg/S42ImV5hj2DiTbZsrXGvswAS8OkguC8wIXfQtee4QNFLLyksDjm CumQ== X-Forwarded-Encrypted: i=1; AJvYcCUYPeBVDqlV/Ner66jkUM2KtAYQuWdcE/jfx5s/YoOXZkYY6nLnFanRJ0trcVBZh8ooL/64l3OeLjzfkP8=@vger.kernel.org X-Gm-Message-State: AOJu0YwNeD33TuF1JKz2qR+UWI0FQjyLSrGgLgp9gZfh6dSKzH56YLQ0 fkWYMJVjWTMYI+iVdnBbWBLtLOAu9DcIDhvqdzHd1T95N40s5q0AV3hm X-Gm-Gg: AZuq6aLKMv7GiaUzvWhBKzRpnvOdsq/lHG7e1cS431C+WPvSwwEyMOsW6+p70vkBGt+ t+kinyaLcS+kbFbFaKvuf01PoOq12RuYRx+U5KPFZ8sE8urEqvG2T1+aitC8VfXeJjWQ3tgyzR3 NRJj0qNnN3izrxzDnEYuFm9m64PRjeCA1RUJyOM1k2qMRcQf2oHMQHSBADDZZXTkGjNNee/N5M4 mbUA0Lkw/1XIonsfGHR+A/eQnKU+i8GDBNhBmJFoeFBfIeiGJKbIZ+JMMdbRvG83y7+O7Dad7qL m93m3y/CkFCB+0BTZ/HmAWRck8xajgDm6njbOXRa0IKkbNNjPqto6eMoUp2p9MTZ1+YtR8ebHJD gPNtPD8gzYjLPKb/dzNzjVBxVhwbZ7FakCeUNrPhVvezTjiJOYq18Ig+diONJocxp/SStuDxJQl b4Hp/34pFXb1hoVTPEZRe/wdQgt/4pi5UXCJdbxxEUPCbgBW+S7Z0EHKhvjWPl X-Received: by 2002:a05:6102:2907:b0:5fe:2c9:667d with SMTP id ada2fe7eead31-5feb2e91949mr2883091137.2.1771710720503; Sat, 21 Feb 2026 13:52:00 -0800 (PST) Received: from smtpclient.apple ([2804:14d:72b4:81ae:7df3:c7c1:3d5:28e6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5feb643068asm3132599137.10.2026.02.21.13.51.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Feb 2026 13:51:59 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH v2] media: vidtv: fix pass-by-value structs causing MSAN warnings From: Daniel Almeida In-Reply-To: <20260221125618.133570-1-abd.masalkhi@gmail.com> Date: Sat, 21 Feb 2026 18:51:44 -0300 Cc: mchehab@kernel.org, thomas.weissschuh@linutronix.de, dingyihan@uniontech.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260221125618.133570-1-abd.masalkhi@gmail.com> To: Abd-Alrhman Masalkhi X-Mailer: Apple Mail (2.3826.700.81) Hi there, thanks for your contribution. > On 21 Feb 2026, at 09:56, Abd-Alrhman Masalkhi = wrote: >=20 > vidtv_ts_null_write_into() and vidtv_ts_pcr_write_into() take their > argument structs by value, causing MSAN to report uninit-value = warnings. > While only vidtv_ts_null_write_into() has triggered a report so far, > both functions share the same issue. >=20 > Fix by passing both structs by const pointer instead, avoiding the > stack copy of the struct along with its MSAN shadow and origin = metadata. > The functions do not modify the structs, which is enforced by the = const > qualifier. >=20 > Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver") > Reported-by: syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=3D96f901260a0b2d29cd1a > Tested-by: syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com > Suggested-by: Yihan Ding > Signed-off-by: Abd-Alrhman Masalkhi > =E2=80=94 I will eventually get to this patch. =E2=80=94 Daniel