From: Christian Hewitt <christianshewitt@gmail.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Soeren Moch <smoch@web.de>, Kalle Valo <kvalo@codeaurora.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset
Date: Tue, 24 Dec 2019 13:44:55 +0400 [thread overview]
Message-ID: <F311713B-D7DC-4029-90F2-5E162648349D@gmail.com> (raw)
In-Reply-To: <3c42d6de-670d-fee8-aa81-99f44d447e87@broadcom.com>
> On 24 Dec 2019, at 1:01 pm, Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
>
> Can you elaborate on the "known SDIO issue"? Is it an issue with ADMA or something else. I am asking because there is a workaround in brcmfmac to avoid scatter-gather lists, which may or may not address the issue.
This describes the issue: https://patchwork.kernel.org/cover/10962975/
Below is the current workaround I’m using, which restricts the hack to Amlogic G12A and G12B devices that inherit “amlogic,dram-access-quirk” from a common SoC dtsi.
https://github.com/chewitt/linux/commit/187527747861b047c835f494fe3267d9b4959be1
Testing by Khadas staff found the max_segs/max_blk_count values and shows a performance impact (not a big surprise) but they appear to give a stable connection, which is better than a very unstable one. I’ve flagged things to linux-amlogic maintainer Neil Armstrong (on CC) and I expect he or colleagues will take a more scientific look in January.
NB: I’m happy to test other things. Just remember that I don’t code so you need to spoon-feed me with patches not suggestions.
Christian
prev parent reply other threads:[~2019-12-24 9:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 23:52 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 1/9] brcmfmac: reset two D11 cores if chip has two D11 cores Soeren Moch
2019-12-18 19:08 ` Kalle Valo
2019-12-11 23:52 ` [PATCH v2 2/9] brcmfmac: set F2 blocksize and watermark for 4359 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 3/9] brcmfmac: fix rambase for 4359/9 Soeren Moch
2019-12-12 2:07 ` Chi-Hsien Lin
2019-12-11 23:52 ` [PATCH v2 4/9] brcmfmac: make errors when setting roaming parameters non-fatal Soeren Moch
2019-12-11 23:52 ` [PATCH v2 5/9] brcmfmac: add support for BCM4359 SDIO chipset Soeren Moch
2019-12-12 1:02 ` Soeren Moch
2019-12-12 2:09 ` Chi-Hsien Lin
2019-12-12 8:33 ` Ulf Hansson
2019-12-11 23:52 ` [PATCH v2 6/9] brcmfmac: add RSDB condition when setting interface combinations Soeren Moch
2019-12-11 23:52 ` [PATCH v2 7/9] brcmfmac: not set mbss in vif if firmware does not support MBSS Soeren Moch
2019-12-11 23:52 ` [PATCH v2 8/9] arm64: dts: rockchip: RockPro64: enable wifi module at sdio0 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 9/9] arm64: dts: rockchip: RockPro64: hook up bluetooth at uart0 Soeren Moch
2019-12-12 10:22 ` Robin Murphy
2019-12-12 10:47 ` Soeren Moch
2019-12-12 9:42 ` [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Kalle Valo
[not found] ` <0101016ef97cf6b5-2552a5e4-12de-4616-94d6-b63d9c795ed6-000000@us-west-2.amazonses.com>
2019-12-12 10:59 ` Soeren Moch
2019-12-15 21:24 ` Soeren Moch
2019-12-15 23:43 ` Heiko Stübner
2020-03-13 11:03 ` Chi-Hsien Lin
2020-03-13 13:17 ` Soeren Moch
2020-03-15 7:01 ` Chi-Hsien Lin
2019-12-18 11:55 ` Christian Hewitt
2019-12-18 23:04 ` Soeren Moch
2019-12-22 4:35 ` Christian Hewitt
2019-12-24 9:01 ` Arend Van Spriel
2019-12-24 9:44 ` Christian Hewitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F311713B-D7DC-4029-90F2-5E162648349D@gmail.com \
--to=christianshewitt@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=heiko@sntech.de \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=smoch@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®