From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Divya Indi <divya.indi@oracle.com>
Cc: linux-kernel@vger.kernel.org, Joe Jin <joe.jin@oracle.com>
Subject: Re: [PATCH] tracing: Kernel access to Ftrace instances
Date: Wed, 15 May 2019 20:24:43 -0700 [thread overview]
Message-ID: <F331FDC8-9E63-4042-A933-BDC197C9A031@goodmis.org> (raw)
In-Reply-To: <20190516120529.4c1f6e6ddd516185df149625@kernel.org>
On May 15, 2019 8:05:29 PM PDT, Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
>> >> diff --git a/kernel/trace/trace_events.c
>b/kernel/trace/trace_events.c
>> >> index 5b3b0c3..81c038e 100644
>> >> --- a/kernel/trace/trace_events.c
>> >> +++ b/kernel/trace/trace_events.c
>> >> @@ -832,6 +832,7 @@ static int ftrace_set_clr_event(struct
>trace_array *tr, char *buf, int set)
>> >>
>> >> return ret;
>> >> }
>> >> +EXPORT_SYMBOL_GPL(ftrace_set_clr_event);
>> > I found this exports a static function to module. Did it work?
>>
>> I had tested the changes with my module. This change to static was
>added
>> in the test patch, but somehow missed it in the final patch that was
>> sent out.
>
>If you can send some example module patch under samples/, that is more
>helpful for us to check it. And it is possible to use in kselftest too.
>
>>
>> Will send a new patch along with a few additional ones to add some
>NULL
>> checks to ensure safe usage by modules and add the APIs to a header
>file
>> that can be used by the modules.
>
>It seems your's already in Steve's ftrace/core branch, so I think you
>can make
>additional patch to fix it. Steve, is that OK?
>
Yes. In fact I already sent a pull request to Linus. Please send a patch on top of my ftrace/core branch.
Thanks,
-- Steve
>Thank you,
>
>>
>> Thanks,
>>
>> Divya
>>
>> >
>> > Thank you,
>> >
--
Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.
next prev parent reply other threads:[~2019-05-16 3:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:28 [RFC] " Divya Indi
2019-03-20 18:28 ` [PATCH] tracing: " Divya Indi
2019-03-27 16:29 ` Steven Rostedt
2019-05-16 0:09 ` Masami Hiramatsu
2019-05-16 1:51 ` Divya Indi
2019-05-16 3:05 ` Masami Hiramatsu
2019-05-16 3:24 ` Steven Rostedt [this message]
2019-05-20 15:23 ` Steven Rostedt
2019-05-20 15:29 ` divya.indi
-- strict thread matches above, loose matches on Subject: below --
2019-03-15 23:35 [RFC] " Divya Indi
2019-03-15 23:35 ` [PATCH] tracing: Kernel access to ftrace instances Divya Indi
2019-03-19 20:16 ` Steven Rostedt
2019-03-20 18:20 ` divya.indi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F331FDC8-9E63-4042-A933-BDC197C9A031@goodmis.org \
--to=rostedt@goodmis.org \
--cc=divya.indi@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®