From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>, Willy Tarreau <w@1wt.eu>
Cc: Jingbo Xu <jefflexu@linux.alibaba.com>,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG REPORT] arch/x86/include/asm/uaccess_64.h:119: Error: junk at end of line
Date: Mon, 17 Apr 2023 11:32:19 -0700 [thread overview]
Message-ID: <F3AC1D23-D1B7-4036-BF52-1CC4FD6C3EAD@zytor.com> (raw)
In-Reply-To: <20230417181417.GHZD2MeRSuMWUPEU3V@fat_crate.local>
On April 17, 2023 11:14:17 AM PDT, Borislav Petkov <bp@alien8.de> wrote:
>On Sun, Apr 16, 2023 at 10:36:36AM +0200, Willy Tarreau wrote:
>> ...
>> So it just means that the support for the "U" suffix on numbers was
>> added in binutils 2.27 and the "L" suffix on numbers was added somewhere
>> between 2.27 and 2.29.
>
>Thanks for that - I'd like to document this once I've hashed out with
>the toolchain person the proper binutils versions which got this
>support. But that'll come later.
>
>> And given that there's a single occurrence of all this in the whole tree,
>> that's why I'm proposing to just get back to the good old (1 << 0) instead
>> of BIT(0).
>
>Yeah, we have those UC() macro things but they don't work in inline asm
>in C code. So yeah, pls do the thing you're suggesting.
>
>Thx.
>
We do have assembly-aware macros for this; I believe they are called _UL() etc.
next prev parent reply other threads:[~2023-04-17 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 3:12 Jingbo Xu
2023-03-14 10:23 ` Borislav Petkov
2023-03-14 11:04 ` Jingbo Xu
2023-04-15 17:56 ` Willy Tarreau
2023-04-15 18:56 ` Borislav Petkov
2023-04-16 8:36 ` Willy Tarreau
2023-04-17 18:14 ` Borislav Petkov
2023-04-17 18:32 ` H. Peter Anvin [this message]
2023-04-17 19:26 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3AC1D23-D1B7-4036-BF52-1CC4FD6C3EAD@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=w@1wt.eu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®