From: Benjamin Coddington <bcodding@redhat.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Aring <alex.aring@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] filelock: add new locks_wake_up_waiter() helper
Date: Mon, 02 Jun 2025 09:09:01 -0400 [thread overview]
Message-ID: <F3D97B2E-1693-4E31-BBF8-63F7F550ADCB@redhat.com> (raw)
In-Reply-To: <20250602-filelock-6-16-v1-1-7da5b2c930fd@kernel.org>
On 2 Jun 2025, at 7:58, Jeff Layton wrote:
> Currently the function that does this takes a struct file_lock, but
> __locks_wake_up_blocks() deals with both locks and leases. Currently
> this works because both file_lock and file_lease have the file_lock_core
> at the beginning of the struct, but it's fragile to rely on that.
>
> Add a new locks_wake_up_waiter() function and call that from
> __locks_wake_up_blocks().
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
Looks good,
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Ben
prev parent reply other threads:[~2025-06-02 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 11:58 Jeff Layton
2025-06-02 12:14 ` Christian Brauner
2025-06-02 13:09 ` Benjamin Coddington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3D97B2E-1693-4E31-BBF8-63F7F550ADCB@redhat.com \
--to=bcodding@redhat.com \
--cc=alex.aring@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®