From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585AbdB1G22 (ORCPT ); Tue, 28 Feb 2017 01:28:28 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36383 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdB1G2X (ORCPT ); Tue, 28 Feb 2017 01:28:23 -0500 Date: Mon, 27 Feb 2017 22:20:54 -0800 User-Agent: K-9 Mail for Android In-Reply-To: <58B51517.4050003@denx.de> References: <1487579863-7256-1-git-send-email-hs@denx.de> <06af466d-ac78-ea38-77d2-3bf32a6e157c@lechnology.com> <58B5084A.9000709@denx.de> <58B51517.4050003@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Subject: Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL To: hs@denx.de, David Lechner CC: linux-input@vger.kernel.org, Guan Ben , Mark Jonas , devicetree@vger.kernel.org, Thierry Reding , linux-kernel@vger.kernel.org, Boris Brezillon , Rob Herring , Manfred Schlaegl , Mark Rutland From: Dmitry Torokhov Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1S6SXa6017921 On February 27, 2017 10:13:43 PM PST, Heiko Schocher wrote: >Hello David, > >Am 28.02.2017 um 06:30 schrieb David Lechner: >> On 02/27/2017 11:19 PM, Heiko Schocher wrote: >>> Hello David, >>> >>> Am 27.02.2017 um 19:11 schrieb David Lechner: >>>> On 02/20/2017 02:37 AM, Heiko Schocher wrote: >>>>> From: Guan Ben >>>>> >>>>> extend the pwm-beeper driver to support customized frequency >>>>> for SND_BELL from device tree. >>>>> >>>>> Signed-off-by: Guan Ben >>>>> Signed-off-by: Mark Jonas >>>>> [hs@denx.de: adapted to 4.10-rc7] >>>>> Signed-off-by: Heiko Schocher >>>>> --- >>>>> >>>>> Changes in v2: >>>>> - add comment from Rob Herring: >>>>> rename property name "bell-frequency" to "beeper-hz" >>>> >>>> Is there a separate patch for the devicetree bindings >documentation? >>> >>> No, it is in this patch ... In the meantime I got an >>> Acked-by from Rob Herring ... >>> >> >> What I should have said is that, in general, I think it is preferred >to have the device tree >> bindings as a separate patch from the code changes. > >I can split this into 2 patches ... Don't - since Rob already asked DT change you don't need to post to device tree list again and I'll merge them back together since they do not make sense separately. Thanks. -- Dmitry