mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: Qiliang Yuan <odys.yuan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Subject: Re: [PATCH v3 1/2] selftests/mm: track the modules run_vmtests.sh loads
Date: Thu, 29 Oct 2026 22:14:47 -0400	[thread overview]
Message-ID: <F4BF41F0-3148-41E2-862F-DA83D9B5BA42@nvidia.com> (raw)
In-Reply-To: <20261029-bug-selftests-mm-run-vmtests-xfs-modprobe-v3-1-16ad772850ee@gmail.com>

On 29 Oct 2026, at 2:24, Qiliang Yuan wrote:

> run_vmtests.sh loads hwpoison_inject for the memory-failure test when it
> is not there yet, remembers that in a variable local to run_test() and
> unloads the module right after the test.
>
> The thp tests need xfs loaded in the same way, and repeating the load,
> the bookkeeping and the unload for every module that some test needs
> does not scale.
>
> Add load_module(), which loads a module unless it is already present
> and records it, and unload every recorded module, in reverse order,
> before the script exits. Use it for hwpoison_inject.
>
> Signed-off-by: Qiliang Yuan <odys.yuan@gmail.com>
> Tested-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> Reviewed-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 31 +++++++++++++++++++++++--------
>  1 file changed, 23 insertions(+), 8 deletions(-)
>
Thanks.

Acked-by: Zi Yan <ziy@nvidia.com>

Best Regards,
Yan, Zi

  reply	other threads:[~2026-10-30  2:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  6:24 [PATCH v3 0/2] selftests/mm: run the XFS-backed THP tests when xfs is a module Qiliang Yuan
2026-10-29  6:24 ` [PATCH v3 1/2] selftests/mm: track the modules run_vmtests.sh loads Qiliang Yuan
2026-10-30  2:14   ` Zi Yan [this message]
2026-10-29  6:24 ` [PATCH v3 2/2] selftests/mm: load xfs before checking for it in run_vmtests.sh Qiliang Yuan
2026-10-29 10:35   ` Jose A. Perez de Azpillaga
2026-10-30  2:17   ` Zi Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F4BF41F0-3148-41E2-862F-DA83D9B5BA42@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=azpijr@gmail.com \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=odys.yuan@gmail.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®