From: Kumar Gala <galak@kernel.crashing.org>
To: benh@kernel.crashing.org
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
htejun@gmail.com, Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, Emilian.Medve@Freescale.com,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] [POWERPC] devres: Add devm_ioremap_flags()
Date: Wed, 30 Apr 2008 16:49:05 -0500 [thread overview]
Message-ID: <F4E7A0B8-894F-4903-855E-6A4BE63CF8D5@kernel.crashing.org> (raw)
In-Reply-To: <1209591750.18023.233.camel@pasglop>
On Apr 30, 2008, at 4:42 PM, Benjamin Herrenschmidt wrote:
>
> On Wed, 2008-04-30 at 11:08 -0500, Kumar Gala wrote:
>> From: Emil Medve <Emilian.Medve@Freescale.com>
>>
>> We provide an ioremap_flags so provide a coresphonding
>> devm_ioremap_flags.
>>
>> Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>>
>> Forgot to commit the actual implemtation in arch/powerpc/lib/devres.c
>>
>> Which tree should this go through, powerpc.git?
>
> Let's call it ioremap_prot instead please. I'm about to change
> ioremap_flags to ioremap_prot anyways. Keep the flags/prot argument
> unsigned long for now (it can be argued it should be a pgprot but that
> hasn't been sorted out completely).
No problem. I've always wondered why ioremap_* aren't better
specified by generic code.
- k
next prev parent reply other threads:[~2008-04-30 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 16:08 Kumar Gala
2008-04-30 17:31 ` Andrew Morton
2008-04-30 21:42 ` Benjamin Herrenschmidt
2008-04-30 21:49 ` Kumar Gala [this message]
2008-05-01 1:18 ` Stephen Rothwell
2008-05-01 1:29 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F4E7A0B8-894F-4903-855E-6A4BE63CF8D5@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=Emilian.Medve@Freescale.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®