From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5286FC432BE for ; Thu, 19 Aug 2021 15:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 349D060E76 for ; Thu, 19 Aug 2021 15:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239995AbhHSPMa (ORCPT ); Thu, 19 Aug 2021 11:12:30 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:49935 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238587AbhHSPM2 (ORCPT ); Thu, 19 Aug 2021 11:12:28 -0400 Received: from smtpclient.apple (p5b3d23f8.dip0.t-ipconnect.de [91.61.35.248]) by mail.holtmann.org (Postfix) with ESMTPSA id ABA47CED16; Thu, 19 Aug 2021 17:11:50 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH v3] Bluetooth: btusb: Remove WAKEUP_DISABLE and add WAKEUP_AUTOSUSPEND for Realtek devices From: Marcel Holtmann In-Reply-To: <20210817030312.27755-1-max.chou@realtek.com> Date: Thu, 19 Aug 2021 17:11:50 +0200 Cc: Johan Hedberg , Luiz Augusto von Dentz , matthias.bgg@gmail.com, "open list:BLUETOOTH SUBSYSTEM" , open list , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alex Lu , Hilda Wu , kidman@realtek.com, Archie Pusaka , Abhishek Pandit-Subedi , josephsih@chromium.org Content-Transfer-Encoding: 7bit Message-Id: References: <20210817030312.27755-1-max.chou@realtek.com> To: Max Chou X-Mailer: Apple Mail (2.3654.120.0.1.13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Max, > For the commit of 9e45524a011107a73bc2cdde8370c61e82e93a4d, wakeup is > always disabled for Realtek devices. However, there's the capability > for Realtek devices to apply USB wakeup. > > In this commit, remove WAKEUP_DISABLE feature for Realtek devices. > If users would switch wakeup, they should access > "/sys/bus/usb/.../power/wakeup" > > In this commit, it also adds the feature as WAKEUP_AUTOSUSPEND > for Realtek devices because it should set do_remote_wakeup on autosuspend. > > Signed-off-by: Max Chou > Tested-by: Hilda Wu > Reviewed-by: Archie Pusaka > Reviewed-by: Abhishek Pandit-Subedi > --- > Changes in v2: > -fix the compiling error due to the incorrect patch file submited > > Changes in v3: > -do rebase and make the patch on the latest revision > --- > drivers/bluetooth/btusb.c | 28 +++++++++------------------- > 1 file changed, 9 insertions(+), 19 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel