From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161358AbcHENZw (ORCPT ); Fri, 5 Aug 2016 09:25:52 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:56479 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758077AbcHENZu convert rfc822-to-8bit (ORCPT ); Fri, 5 Aug 2016 09:25:50 -0400 From: "Altshul, Maxim" To: Johannes Berg , "linux-kernel@vger.kernel.org" CC: "john.stultz@linaro.org" , Kalle Valo , Eliad Peller , "Machani, Yaniv" Subject: RE: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput Thread-Topic: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput Thread-Index: AQHR7k0rvt6HGsVs9USjRnz3fDXuTKA6Kf4AgAAAjQCAAC5WIw== Date: Fri, 5 Aug 2016 13:25:42 +0000 Message-ID: References: <20160804124314.7636-1-maxim.altshul@ti.com> <20160804124314.7636-2-maxim.altshul@ti.com> <1470399762.2977.40.camel@sipsolutions.net>,<1470399880.2977.41.camel@sipsolutions.net> In-Reply-To: <1470399880.2977.41.camel@sipsolutions.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.247.5.92] x-exclaimer-md-config: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 1) Sorry about the change log, I will try to be clearer next time. 2+3) The issue is not that the station is not known, it's that wl_sta->wl was null. wl member is now completely removed from wl_sta (PATCH 2/2) and hw is sent directly from mac80211 to the driver (so it can get hw->priv). 4) Sorry, I just saw now that everything has a space before the line. I used checkpatch.pl and it was ok. I will be more careful next time. BR, Max ________________________________________ From: Johannes Berg [johannes@sipsolutions.net] Sent: Friday, August 05, 2016 3:24 PM To: Altshul, Maxim; linux-kernel@vger.kernel.org Cc: john.stultz@linaro.org; Kalle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > I'm applying this now, with a big BUT: > > 1) your changelog is crap - I've rewritten it to indicate what's > going > on > > 2) I think the change makes sense, but as far as fixing the bug is > concerned it's actually completely stupid > > 3) I expect you to submit a proper bugfix for mac80211 ASAP, to not > call into the driver before the station is actually known to the > driver. 4) please indent your code properly when submitting... johannes