Re: [PATCH v6 5/6] platform/x86: Add Lenovo WMI Gamezone Driver

["Derek J. Clark" <derekjohn.clark@gmail.com>]

On April 28, 2025 9:39:55 PM PDT, ALOK TIWARI <alok.a.tiwari@oracle.com> wrote:
>
>
>On 28-04-2025 06:48, Derek J. Clark wrote:
>> + * Determine if the extreme thermal mode is supported by the hardware.
>> + * Anything version 5 or lower does not. For devices wuth a version 6 or
>
>typo wuth
>
>> + * greater do a DMI check, as some devices report a version that supports
>> + * extreme mode but have an incomplete entry in the BIOS. To ensure this
>> + * cannot be set, quirk them to prevent assignment.
>> + *
>> + * Return: int.
>
>The function returns int.
>But logically it's returning boolean false, true

I may have overdone it by removing all bools after the v5 review as I interpreted Ilpo's comment to mean I shouldn't return any bool c types. I'll wait for them to weigh in before changing this back.

>> + */
>> +static int lwmi_gz_extreme_supported(int profile_support_ver)
>> +{
>> +	const struct dmi_system_id *dmi_id;
>> +	struct quirk_entry *quirks;
>> +
>> +	if (profile_support_ver < 6)
>> +		return false;
>> +
>> +	dmi_id = dmi_first_match(fwbug_list);
>> +	if (!dmi_id)
>> +		return true;
>> +
>> +	quirks = dmi_id->driver_data;
>> +	return quirks->extreme_supported;
>> +}
>
>Thank,
>Alok

Thanks,
- Derek